Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754049Ab3H0Tei (ORCPT ); Tue, 27 Aug 2013 15:34:38 -0400 Received: from mga02.intel.com ([134.134.136.20]:29246 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753469Ab3H0Teg (ORCPT ); Tue, 27 Aug 2013 15:34:36 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.89,970,1367996400"; d="scan'208";a="394301968" Date: Tue, 27 Aug 2013 12:34:33 -0700 From: Jesse Brandeburg To: Joe Perches Cc: , , , , , , jesse.brandeburg@intel.com Subject: Re: [PATCH net-next] drivers:net: Convert dma_alloc_coherent(...__GFP_ZERO) to dma_zalloc_coherent Message-ID: <20130827123433.00002cb7@unknown> In-Reply-To: <1377582323.2658.10.camel@joe-AO722> References: <1377582323.2658.10.camel@joe-AO722> X-Mailer: Claws Mail 3.7.10cvs7 (GTK+ 2.16.6; i586-pc-mingw32msvc) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 889 Lines: 26 On Mon, 26 Aug 2013 22:45:23 -0700 Joe Perches wrote: > __GFP_ZERO is an uncommon flag and perhaps is better > not used. static inline dma_zalloc_coherent exists > so convert the uses of dma_alloc_coherent with __GFP_ZERO > to the more common kernel style with zalloc. > > Remove memset from the static inline dma_zalloc_coherent > and add just one use of __GFP_ZERO instead. > > Trivially reduces the size of the existing uses of > dma_zalloc_coherent. > > Realign arguments as appropriate. > > Signed-off-by: Joe Perches e1000 and ixgb bits: Acked-by: Jesse Brandeburg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/