Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754117Ab3H0UGE (ORCPT ); Tue, 27 Aug 2013 16:06:04 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:35514 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753847Ab3H0UGB (ORCPT ); Tue, 27 Aug 2013 16:06:01 -0400 Message-ID: <521D0682.4020908@ti.com> Date: Wed, 28 Aug 2013 01:35:22 +0530 From: Sekhar Nori User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: "Lad, Prabhakar" CC: DLOS , LKML , LAK , Linus Walleij , Grant Likely , Kevin Hilman Subject: Re: [PATCH v3 5/7] ARM: davinci: da8xx: gpio device creation References: <1376803143-13738-1-git-send-email-prabhakar.csengg@gmail.com> <1376803143-13738-6-git-send-email-prabhakar.csengg@gmail.com> In-Reply-To: <1376803143-13738-6-git-send-email-prabhakar.csengg@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 7675 Lines: 233 On 8/18/2013 10:49 AM, Lad, Prabhakar wrote: > From: Philip Avinash > > Create davinci gpio device and remove references in davinci_soc_info > structure. Also rearrange header file inclusion in group basis. > > Signed-off-by: Philip Avinash > Signed-off-by: Sekhar Nori > Signed-off-by: Lad, Prabhakar > Acked-by: Linus Walleij > --- > arch/arm/mach-davinci/board-da830-evm.c | 28 ++++++++++++++++----------- > arch/arm/mach-davinci/board-da850-evm.c | 16 ++++++++++----- > arch/arm/mach-davinci/board-omapl138-hawk.c | 10 ++++++++-- > arch/arm/mach-davinci/da830.c | 21 +++++++++++++++----- > arch/arm/mach-davinci/da850.c | 27 ++++++++++++++++++-------- > arch/arm/mach-davinci/include/mach/da8xx.h | 22 +++++++++++---------- > 6 files changed, 83 insertions(+), 41 deletions(-) > > #define DA850_EVM_PHY_ID "davinci_mdio-0:00" > #define DA850_LCD_PWR_PIN GPIO_TO_PIN(2, 8) > @@ -1439,6 +1441,10 @@ static __init void da850_evm_init(void) > { > int ret; > > + ret = da850_register_gpio(); > + if (ret) > + pr_warn("da850_evm_init: GPIO init failed: %d\n", ret); Changed this to use __func__ for function name print to remain consistent with rest of this function. > +int __init da830_register_gpio() This should be da830_register_gpio(void). Please check the patches you submit for compilation warnings. > +int __init da850_register_gpio() Same problem here too. Here is the updated patch. Now with just the board updates. Thanks, Sekhar ---8<--- >From daa3db9c70850578e041bb57d3ae8cc6d17ef7f3 Mon Sep 17 00:00:00 2001 From: Philip Avinash Date: Sun, 18 Aug 2013 10:49:01 +0530 Subject: [PATCH 5/7] ARM: davinci: da8xx boards: gpio device creation Register gpio platform device on DA8XX boards. While at it, rearrange header files to group related header files together and sort them in alphabetic order within the group. This will help avoid duplicate inclusions in future. Signed-off-by: Philip Avinash [nsekhar@ti.com: remove SoC specific parts from this file. fix compile warnings] Signed-off-by: Sekhar Nori Signed-off-by: Lad, Prabhakar Acked-by: Linus Walleij --- arch/arm/mach-davinci/board-da830-evm.c | 28 ++++++++++++++++----------- arch/arm/mach-davinci/board-da850-evm.c | 16 ++++++++++----- arch/arm/mach-davinci/board-omapl138-hawk.c | 10 ++++++++-- 3 files changed, 36 insertions(+), 18 deletions(-) diff --git a/arch/arm/mach-davinci/board-da830-evm.c b/arch/arm/mach-davinci/board-da830-evm.c index c4bdc0a..54a8690 100644 --- a/arch/arm/mach-davinci/board-da830-evm.c +++ b/arch/arm/mach-davinci/board-da830-evm.c @@ -9,30 +9,32 @@ * is licensed "as is" without any warranty of any kind, whether express * or implied. */ -#include -#include #include -#include #include -#include #include -#include #include +#include +#include +#include +#include #include #include -#include +#include +#include +#include +#include +#include +#include #include +#include #include #include +#include #include -#include -#include #include -#include -#include -#include +#include #define DA830_EVM_PHY_ID "" /* @@ -591,6 +593,10 @@ static __init void da830_evm_init(void) struct davinci_soc_info *soc_info = &davinci_soc_info; int ret; + ret = da830_register_gpio(); + if (ret) + pr_warn("da830_evm_init: GPIO init failed: %d\n", ret); + ret = da830_register_edma(da830_edma_rsv); if (ret) pr_warning("da830_evm_init: edma registration failed: %d\n", diff --git a/arch/arm/mach-davinci/board-da850-evm.c b/arch/arm/mach-davinci/board-da850-evm.c index 9afd687..31d55a1 100644 --- a/arch/arm/mach-davinci/board-da850-evm.c +++ b/arch/arm/mach-davinci/board-da850-evm.c @@ -15,29 +15,31 @@ #include #include #include -#include -#include #include #include #include +#include #include #include +#include #include #include #include #include #include -#include +#include #include #include #include #include +#include #include #include -#include #include +#include #include +#include #include #include #include @@ -47,8 +49,8 @@ #include #include -#include #include +#include #define DA850_EVM_PHY_ID "davinci_mdio-0:00" #define DA850_LCD_PWR_PIN GPIO_TO_PIN(2, 8) @@ -1439,6 +1441,10 @@ static __init void da850_evm_init(void) { int ret; + ret = da850_register_gpio(); + if (ret) + pr_warn("%s: GPIO init failed: %d\n", __func__, ret); + ret = pmic_tps65070_init(); if (ret) pr_warn("%s: TPS65070 PMIC init failed: %d\n", __func__, ret); diff --git a/arch/arm/mach-davinci/board-omapl138-hawk.c b/arch/arm/mach-davinci/board-omapl138-hawk.c index ab98c75..0e0b998 100644 --- a/arch/arm/mach-davinci/board-omapl138-hawk.c +++ b/arch/arm/mach-davinci/board-omapl138-hawk.c @@ -9,14 +9,16 @@ * version 2. This program is licensed "as is" without any warranty of * any kind, whether express or implied. */ -#include -#include #include #include +#include +#include +#include #include #include +#include #include #include #include @@ -290,6 +292,10 @@ static __init void omapl138_hawk_init(void) { int ret; + ret = da850_register_gpio(); + if (ret) + pr_warn("%s: GPIO init failed: %d\n", __func__, ret); + davinci_serial_init(da8xx_serial_device); omapl138_hawk_config_emac(); -- 1.7.10.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/