Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754125Ab3H0V3b (ORCPT ); Tue, 27 Aug 2013 17:29:31 -0400 Received: from mail-ee0-f43.google.com ([74.125.83.43]:51971 "EHLO mail-ee0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753836Ab3H0V21 (ORCPT ); Tue, 27 Aug 2013 17:28:27 -0400 From: Sebastian Hesselbarth To: Sebastian Hesselbarth Cc: Soren Brinkmann , Michal Simek , Mike Turquette , Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH RFC v2 16/16] ARM: zynq: Don't call of_clk_init() Date: Tue, 27 Aug 2013 23:28:10 +0200 Message-Id: <1377638890-371-17-git-send-email-sebastian.hesselbarth@gmail.com> X-Mailer: git-send-email 1.7.2.5 In-Reply-To: <1376964271-22715-1-git-send-email-sebastian.hesselbarth@gmail.com> References: <1376964271-22715-1-git-send-email-sebastian.hesselbarth@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2776 Lines: 85 From: Soren Brinkmann of_clk_init() has been moved to be called from common code, therefore remove it from Zynq's clock init routine. Since the Zynq's clock setup routine relies on an initialized SLCR, zynq_slcr_init() is moved to init_irq() instead. Signed-off-by: Soren Brinkmann --- Cc: Michal Simek Cc: Mike Turquette Cc: Russell King Cc: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- arch/arm/mach-zynq/common.c | 9 ++++----- drivers/clk/zynq/clkc.c | 4 +++- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/arch/arm/mach-zynq/common.c b/arch/arm/mach-zynq/common.c index 5f25256..9f79ebb 100644 --- a/arch/arm/mach-zynq/common.c +++ b/arch/arm/mach-zynq/common.c @@ -19,8 +19,7 @@ #include #include #include -#include -#include +#include #include #include #include @@ -58,10 +57,10 @@ static void __init zynq_init_machine(void) of_platform_bus_probe(NULL, zynq_of_bus_ids, NULL); } -static void __init zynq_timer_init(void) +static void __init zynq_init_irq(void) { + irqchip_init(); zynq_slcr_init(); - clocksource_of_init(); } static struct map_desc zynq_cortex_a9_scu_map __initdata = { @@ -104,8 +103,8 @@ static const char * const zynq_dt_match[] = { DT_MACHINE_START(XILINX_EP107, "Xilinx Zynq Platform") .smp = smp_ops(zynq_smp_ops), .map_io = zynq_map_io, + .init_irq = zynq_init_irq, .init_machine = zynq_init_machine, - .init_time = zynq_timer_init, .dt_compat = zynq_dt_match, .restart = zynq_system_reset, MACHINE_END diff --git a/drivers/clk/zynq/clkc.c b/drivers/clk/zynq/clkc.c index 089d3e3..53b851e 100644 --- a/drivers/clk/zynq/clkc.c +++ b/drivers/clk/zynq/clkc.c @@ -206,6 +206,9 @@ static void __init zynq_clk_setup(struct device_node *np) pr_info("Zynq clock init\n"); + if (WARN_ON(!zynq_slcr_base_priv)) + return; + /* get clock output names from DT */ for (i = 0; i < clk_max; i++) { if (of_property_read_string_index(np, "clock-output-names", @@ -532,5 +535,4 @@ CLK_OF_DECLARE(zynq_clkc, "xlnx,ps7-clkc", zynq_clk_setup); void __init zynq_clock_init(void __iomem *slcr_base) { zynq_slcr_base_priv = slcr_base; - of_clk_init(NULL); } -- 1.7.2.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/