Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754013Ab3H0V7p (ORCPT ); Tue, 27 Aug 2013 17:59:45 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:51734 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752766Ab3H0V7o (ORCPT ); Tue, 27 Aug 2013 17:59:44 -0400 Message-ID: <521D214C.80809@wwwdotorg.org> Date: Tue, 27 Aug 2013 15:59:40 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 MIME-Version: 1.0 To: Sebastian Hesselbarth CC: Stephen Warren , Russell King , Arnd Bergmann , linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC v2 13/16] ARM: tegra: split tegra_pmc_init() in two References: <1376964271-22715-1-git-send-email-sebastian.hesselbarth@gmail.com> <1377638890-371-14-git-send-email-sebastian.hesselbarth@gmail.com> In-Reply-To: <1377638890-371-14-git-send-email-sebastian.hesselbarth@gmail.com> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1762 Lines: 40 On 08/27/2013 03:28 PM, Sebastian Hesselbarth wrote: > From: Stephen Warren > > Tegra's board file currently initializes clocks much earlier than those > for most other ARM SoCs. The reason is: > > * The PMC HW block is involved in the path of some interrupts (i.e. it > inverts, or not, the IRQ input pin dedicated to the PMIC). > > * So, that part of the PMC must be initialized early so that the IRQ > polarity is correct. > > * The PMC initialization is currently monolithic, and the PMC has some > clock inputs, so the init routine ends up calling of_clk_get_by_name(), > and hence clocks must be set up early too. > > In order to defer clock initialization to the more typical location, > split out the portions of tegra_pmc_init() that are truly IRQ-related > into a separate tegra_pmc_init_irq(), which can be called from the > machine descriptor's .init_irq() function, and defer the rest until > the machine descriptor's .init_machine() function. With arch/arm calling > of_clk_init(NULL) from time_init() this also allows the removal of > .init_time() hook. > > Signed-off-by: Stephen Warren > --- > Changelog: > v1->v2: > - took Stephen Warren's patch provided to separate Tegra's pmc_init > - sqashed in .init_time removal and reworded patch text I think it'd be better to keep the 2 patches separate so the two logical changes are in different patches. I suppose it isn't a huge deal though. Either way, on this patch, your S-o-b line is missing above. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/