Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753866Ab3H0WJb (ORCPT ); Tue, 27 Aug 2013 18:09:31 -0400 Received: from mail-ea0-f181.google.com ([209.85.215.181]:47481 "EHLO mail-ea0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751838Ab3H0WJ3 (ORCPT ); Tue, 27 Aug 2013 18:09:29 -0400 Message-ID: <521D2394.7030005@gmail.com> Date: Wed, 28 Aug 2013 00:09:24 +0200 From: Sebastian Hesselbarth User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Stephen Warren CC: Stephen Warren , Russell King , Arnd Bergmann , linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC v2 13/16] ARM: tegra: split tegra_pmc_init() in two References: <1376964271-22715-1-git-send-email-sebastian.hesselbarth@gmail.com> <1377638890-371-14-git-send-email-sebastian.hesselbarth@gmail.com> <521D214C.80809@wwwdotorg.org> In-Reply-To: <521D214C.80809@wwwdotorg.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2181 Lines: 52 On 08/27/13 23:59, Stephen Warren wrote: > On 08/27/2013 03:28 PM, Sebastian Hesselbarth wrote: >> From: Stephen Warren >> >> Tegra's board file currently initializes clocks much earlier than those >> for most other ARM SoCs. The reason is: >> >> * The PMC HW block is involved in the path of some interrupts (i.e. it >> inverts, or not, the IRQ input pin dedicated to the PMIC). >> >> * So, that part of the PMC must be initialized early so that the IRQ >> polarity is correct. >> >> * The PMC initialization is currently monolithic, and the PMC has some >> clock inputs, so the init routine ends up calling of_clk_get_by_name(), >> and hence clocks must be set up early too. >> >> In order to defer clock initialization to the more typical location, >> split out the portions of tegra_pmc_init() that are truly IRQ-related >> into a separate tegra_pmc_init_irq(), which can be called from the >> machine descriptor's .init_irq() function, and defer the rest until >> the machine descriptor's .init_machine() function. With arch/arm calling >> of_clk_init(NULL) from time_init() this also allows the removal of >> .init_time() hook. >> >> Signed-off-by: Stephen Warren >> --- >> Changelog: >> v1->v2: >> - took Stephen Warren's patch provided to separate Tegra's pmc_init >> - sqashed in .init_time removal and reworded patch text > > I think it'd be better to keep the 2 patches separate so the two logical > changes are in different patches. I suppose it isn't a huge deal though. > > Either way, on this patch, your S-o-b line is missing above. Stephen, I was already wondering here, if I should separate the patches into preparation and actual removal. I put that question into the cover letter and removed it from this patch text ;) As you suggest to use preparation/removal, I will take that approach for the final patch set. Will take you original unmodified patch then. Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/