Date: Tue, 27 Aug 2013 16:04:07 -0700
From: Greg KH <gregkh@linuxfoundation.org>
To: Kevin Hilman <khilman@linaro.org>
Cc: Alexander Savchenko <oleksandr.savchenko@ti.com>, jslaby@suse.cz,
        linux-serial@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
        Ruchika Kharwar <ruchika@ti.com>, balbi@ti.com
Subject: Re: [PATCH] serial: omap: Fix IRQ handling return value
Message-ID: <20130827230407.GA30462@kroah.com>
References: <1374067753-29560-1-git-send-email-oleksandr.savchenko@ti.com>
 <CAGa+x84dE_RwN2G1y_9OJFxnq3JKq5g0YZd+mFueOjjvMzyyew@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAGa+x84dE_RwN2G1y_9OJFxnq3JKq5g0YZd+mFueOjjvMzyyew@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1006
Lines: 30

On Tue, Aug 20, 2013 at 08:44:50AM -0700, Kevin Hilman wrote:
> +Felipe
> 
> On Wed, Jul 17, 2013 at 6:29 AM, Alexander Savchenko
> <oleksandr.savchenko@ti.com> wrote:
> > From: Ruchika Kharwar <ruchika@ti.com>
> >
> > Ensure the Interrupt handling routine return IRQ_HANDLED vs
> > IRQ_NONE.
> 
> Why?
> 
> By unconditionally returning IRQ_HANDLED, this patch will surely break
> systems where the UART IRQ is shared with other platforms.
> 
> I just noticed this patch when bisecting a related problem.  Why
> wasn't this Cc'd to linux-omap where OMAP users might have been more
> likely to see it?
> 
> Greg, without a better justification in the changelog, I think this
> patch should be dropped from tty-next.

Now reverted, sorry for the delay.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/