Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753992Ab3H0XdI (ORCPT ); Tue, 27 Aug 2013 19:33:08 -0400 Received: from dcvr.yhbt.net ([64.71.152.64]:49999 "EHLO dcvr.yhbt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753780Ab3H0XdH (ORCPT ); Tue, 27 Aug 2013 19:33:07 -0400 Date: Tue, 27 Aug 2013 23:33:00 +0000 From: Eric Wong To: Eric Dumazet Cc: Andrew Morton , "linux-kernel@vger.kernel.org" , Al Viro , edumazet@google.com, "Theodore Ts'o" Subject: Re: [PATCH] epoll: add a reschedule point in ep_free() Message-ID: <20130827233300.GA14061@dcvr.yhbt.net> References: <1376751997.21329.8.camel@edumazet-glaptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1376751997.21329.8.camel@edumazet-glaptop> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 816 Lines: 21 Eric Dumazet wrote: > From: Eric Dumazet > > ep_free() might iterate on a huge set of epitems and hold > cpu too long. Add two cond_resched() in order to yield cpu > to other tasks. This is safe as we only hold mutexes in > this function. > > Signed-off-by: Eric Dumazet > Cc: Al Viro > Cc: Theodore Ts'o Seems reasonable. This isn't a remotely hot path and f_op->release runs in a workqueue nowadays (right?). Acked-by: Eric Wong -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/