Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754546Ab3H1Hzy (ORCPT ); Wed, 28 Aug 2013 03:55:54 -0400 Received: from 8bytes.org ([85.214.48.195]:39896 "EHLO mail.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752648Ab3H1Hzx (ORCPT ); Wed, 28 Aug 2013 03:55:53 -0400 Date: Wed, 28 Aug 2013 09:55:50 +0200 From: Joerg Roedel To: Linus Walleij Cc: Russell King - ARM Linux , Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ARM: integrator: Make sure INTEGRATOR_AP depends on PCI Message-ID: <20130828075549.GF20372@8bytes.org> References: <1376509818-22163-1-git-send-email-joro@8bytes.org> <20130814195701.GY23006@n2100.arm.linux.org.uk> <20130814200442.GA20372@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-DSPAM-Result: Whitelisted X-DSPAM-Processed: Wed Aug 28 09:55:51 2013 X-DSPAM-Confidence: 0.9994 X-DSPAM-Probability: 0.0000 X-DSPAM-Signature: 521dad0720861225511102 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1340 Lines: 43 On Wed, Aug 28, 2013 at 09:26:57AM +0200, Linus Walleij wrote: > On Wed, Aug 14, 2013 at 10:04 PM, Joerg Roedel wrote: > > > So when integrator does not depend on PCI this diff is more appropriate? > > > > diff --git a/arch/arm/mach-integrator/pci_v3.h b/arch/arm/mach-integrator/pci_v3.h > > index 755fd29..51738e0 100644 > > --- a/arch/arm/mach-integrator/pci_v3.h > > +++ b/arch/arm/mach-integrator/pci_v3.h > > @@ -1,2 +1,9 @@ > > -/* Simple oneliner include to the PCIv3 early init */ > > +/* Define PCIv3 early init */ > > +#ifdef CONFIG_PCI > > extern int pci_v3_early_init(void); > > +#else > > +static inline int pci_v3_early_init(void) > > +{ > > + return 0; > > +} > > +#endif > > Yes. > Reviewed-by: Linus Walleij > > And can you please create and send a proper patch with this > content to arm@kernel.org and the mailing list on CC, with > a request for the ARM SoC maintainers to apply it directly > as a fix? > > You might as well add Cc: stable@vger.kernel.org as well. Will do, thanks for your review. Cheers, Joerg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/