Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754120Ab3H1NRI (ORCPT ); Wed, 28 Aug 2013 09:17:08 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:33755 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754060Ab3H1NRE (ORCPT ); Wed, 28 Aug 2013 09:17:04 -0400 Message-ID: <521DF806.4030900@ti.com> Date: Wed, 28 Aug 2013 09:15:50 -0400 From: Eduardo Valentin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Zhang Rui CC: "Rafael J. Wysocki" , Eduardo Valentin , , , Anton Vorontsov , David Woodhouse , , Grant Likely , Kukjin Kim , Len Brown , , , , Matthew Garrett , Peter Feuerer , , Rob Herring , Lan Tianyu Subject: Re: [PATCH 3/5] drivers: thermal: make usage of CONFIG_THERMAL_HWMON optional References: <1377295396-17289-1-git-send-email-eduardo.valentin@ti.com> <4832825.8PCMQe7StP@vostro.rjw.lan> <521CEF61.6040504@ti.com> <8131326.8QGX41MW6c@vostro.rjw.lan> <1377648836.2335.252.camel@rzhang-lenovo> In-Reply-To: <1377648836.2335.252.camel@rzhang-lenovo> X-Enigmail-Version: 1.5.2 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mWhQBTIXSPWUdFBXk4Q2HNmMGfgbf8xVc" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3008 Lines: 100 --mWhQBTIXSPWUdFBXk4Q2HNmMGfgbf8xVc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 27-08-2013 20:13, Zhang Rui wrote: > On =E4=BA=8C, 2013-08-27 at 23:17 +0200, Rafael J. Wysocki wrote: >> On Tuesday, August 27, 2013 02:26:41 PM Eduardo Valentin wrote: >>> On 23-08-2013 19:08, Rafael J. Wysocki wrote: >>>> On Friday, August 23, 2013 06:03:14 PM Eduardo Valentin wrote: >>>>> When registering a new thermal_device, the thermal framework >>>>> will always add a hwmon sysfs interface. >>>>> >>>>> This patch adds a flag to make this behavior optional. Now >>>>> when registering a new thermal device, the caller needs >>>>> to say if the hwmon interface is required. >>>>> >>>>> In order to keep same behavior as of today, all current >>>>> calls will by default create the hwmon interface. >>>> >>>> Well, instead of modifying all of the callers this way, why don't >>>> you add new versions taking the additional argument as, for example,= >>>> >>>> thermal_zone_device_register_full() >>>> >>>> and redefine the old ones as static inline wrappers, for example >>>> >>>> static inline struct thermal_zone_device *thermal_zone_device_regist= er(args) >>>> { >>>> return thermal_zone_device_register_full(args, true); >>>> } >>>> >>>> ? >>> >>> Yeah, that is another way to go and I thought of doing it like that. = I >>> just could not come out with a good API naming: >>> >>> thermal_zone_device_register_full(all args) >>> >>> thermal_zone_device_register(args) /* on hwmon =3D=3D true */ >>> thermal_zone_device_register_no_hwmon(args) /* on hwmon =3D=3D false = */ >>> >>> Would this sound reasonable naming? >> >> Yeah, sounds good to me. >> > Well, actually, Tianyu is working on a patch set to move all the > thermal_zone_device_register() parameters to struct thermal_zone_params= =2E >=20 > But with that patch set done, what you need to do next is just to > introduce a new field in struct thermal_zone_params and make sure 0 > means registering hwmon sysfs I/F. Rui, Do you have a pointer to his patch? >=20 > thanks, > rui >=20 >> Thanks, >> Rafael >> >=20 >=20 >=20 >=20 --=20 You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin --mWhQBTIXSPWUdFBXk4Q2HNmMGfgbf8xVc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iF4EAREIAAYFAlId+AoACgkQCXcVR3XQvP2kqQD+Pw7guXqGlaKBfZxUlPAxmFpO 0FpvSYqnSqGxrvIY10EA/jw72f7Ssk7xDeg14e8VfJi3M0jNbGQSm9w8sIVcH2QW =lOEf -----END PGP SIGNATURE----- --mWhQBTIXSPWUdFBXk4Q2HNmMGfgbf8xVc-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/