Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753843Ab3H1Omw (ORCPT ); Wed, 28 Aug 2013 10:42:52 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:13841 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752971Ab3H1Omv (ORCPT ); Wed, 28 Aug 2013 10:42:51 -0400 X-Authority-Analysis: v=2.0 cv=DqnUCRD+ c=1 sm=0 a=Sro2XwOs0tJUSHxCKfOySw==:17 a=Drc5e87SC40A:10 a=nRXi7Rq_KXAA:10 a=5SG0PmZfjMsA:10 a=kj9zAlcOel0A:10 a=meVymXHHAAAA:8 a=KGjhK52YXX0A:10 a=cxZRFzV95EEA:10 a=3nbZYyFuAAAA:8 a=iq4LtzPRMXmoR65u-rAA:9 a=CjuIK1q_8ugA:10 a=EvKJbDF4Ut8A:10 a=-NAFuxVyQHbmMh7N:21 a=6MSNnR1ruyrO26lo:21 a=Sro2XwOs0tJUSHxCKfOySw==:117 X-Cloudmark-Score: 0 X-Authenticated-User: X-Originating-IP: 67.255.60.225 Date: Wed, 28 Aug 2013 10:42:49 -0400 From: Steven Rostedt To: Yoshihiro YUNOMAE Cc: Hidehiro Kawai , Masami Hiramatsu , linux-kernel@vger.kernel.org, yrl.pp-manager.tt@hitachi.com Subject: Re: [RFC PATCH 08/11] trace-cmd: Apply the trace-msg protocol for communication between a server and clients Message-ID: <20130828104249.3533bece@gandalf.local.home> In-Reply-To: <521DDF49.1090301@hitachi.com> References: <20130819094620.26597.79499.stgit@yunodevel> <20130819094639.26597.44449.stgit@yunodevel> <20130820135658.5a5d6e28@gandalf.local.home> <521AB469.40201@hitachi.com> <20130826111105.5d6504e0@gandalf.local.home> <521C7E1C.5060502@hitachi.com> <20130827090509.598591e8@gandalf.local.home> <521DDF49.1090301@hitachi.com> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.20; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1573 Lines: 38 On Wed, 28 Aug 2013 20:30:17 +0900 Yoshihiro YUNOMAE wrote: > (2013/08/27 22:05), Steven Rostedt wrote: > > On Tue, 27 Aug 2013 19:23:24 +0900 > > Yoshihiro YUNOMAE wrote: > > > >> OK, let me check that. Even if the old server will receive "V2", the > >> server will send port numbers instead of "V2" due to the old protocol. > >> In that time, the new client will disconnect from the old server and > >> the restarts with the old protocol. Is it OK? > > > > Yep, that's exactly what I meant ;-) > > I tried to implement the feature, but I found that sending just "V2" > from the new client is inappropriate. This is because the old server > doesn't respond to the client before receiving cpu numbers, page size, > and options. So, when the new client sends the first message, it should > send "V2\0\00\0", I think. If so, the old server will > understand the message as cpus=0, pagesize=, options=0, > and then it will send port numbers(actually \0). Note if > is zero, the old server will die. > > Can I implement the first message of the new client as > "V2\0\00\0"? > If it works for both old and new server with old and new client (and all combinations) I'm fine with it. Thanks, -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/