Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753879Ab3H1RhS (ORCPT ); Wed, 28 Aug 2013 13:37:18 -0400 Received: from mga02.intel.com ([134.134.136.20]:13815 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752335Ab3H1RhQ (ORCPT ); Wed, 28 Aug 2013 13:37:16 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.89,976,1367996400"; d="scan'208";a="369867127" Date: Wed, 28 Aug 2013 10:37:15 -0700 From: Sarah Sharp To: Greg Kroah-Hartman Cc: Dmitry Kasatkin , sedat.dilek@gmail.com, Stephen Rothwell , linux-next , LKML , linux-usb@vger.kernel.org Subject: Re: linux-next: Tree for Aug 28 [ xhci build breakage ] Message-ID: <20130828173715.GE26483@xanatos> References: <521DD43D.7070605@samsung.com> <521DD6BD.4030700@samsung.com> <20130828165938.GA26483@xanatos> <20130828171824.GA5012@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130828171824.GA5012@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1740 Lines: 41 On Wed, Aug 28, 2013 at 10:18:24AM -0700, Greg Kroah-Hartman wrote: > On Wed, Aug 28, 2013 at 09:59:38AM -0700, Sarah Sharp wrote: > > Please trim your replies. > > > > On Wed, Aug 28, 2013 at 01:53:49PM +0300, Dmitry Kasatkin wrote: > > > >>> That change seems to cause the problems: > > > >>> > > > >>> commit 0730d52a86919300a39a2be37f6c140997dfb82f > > > >>> "xhci:prevent "callbacks suppressed" when debug is not enabled" > > > >>> > > > >>> - Sedat - > > > >>> > > > >>> [1] http://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/drivers/usb/host/xhci-ring.c?h=usb-next&id=0730d52a86919300a39a2be37f6c140997dfb82f > > > >>> > > > >> Hello, > > > >> > > > >> [PATCHv2 1/2] was not applied before. > > > >> I pointed this out few hours ago... > > > > So commit 0730d52a86919300a39a2be37f6c140997dfb82f 'xhci:prevent > > "callbacks suppressed" when debug is not enabled' needed to be applied > > after your first patch? And basically applying that patch alone breaks > > the build? > > > > Ugh. Sorry about this. Greg, how do you want to handle this? > > See my other response about your pull request, how about tacking it onto > there? Yeah, you could take the first patch and apply it to the usb-next tree. There would still be a few patches where build breakage occurs, but that will be there regardless of whether we revert that patch, apply the first one, and then re-apply the second one. So just applying the first patch seems to be the better option. Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/