Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753659Ab3H1RjY (ORCPT ); Wed, 28 Aug 2013 13:39:24 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:45531 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752829Ab3H1RjW (ORCPT ); Wed, 28 Aug 2013 13:39:22 -0400 MIME-Version: 1.0 Reply-To: sedat.dilek@gmail.com In-Reply-To: <521E3259.6040201@samsung.com> References: <521DD43D.7070605@samsung.com> <521DD6BD.4030700@samsung.com> <20130828165938.GA26483@xanatos> <521E3259.6040201@samsung.com> Date: Wed, 28 Aug 2013 19:39:14 +0200 Message-ID: Subject: Re: linux-next: Tree for Aug 28 [ xhci build breakage ] From: Sedat Dilek To: Dmitry Kasatkin Cc: Sarah Sharp , Greg Kroah-Hartman , Stephen Rothwell , linux-next , LKML , linux-usb@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1956 Lines: 60 On Wed, Aug 28, 2013 at 7:24 PM, Dmitry Kasatkin wrote: > On 28/08/13 19:59, Sarah Sharp wrote: >> Please trim your replies. >> >> On Wed, Aug 28, 2013 at 01:53:49PM +0300, Dmitry Kasatkin wrote: >>>>>> That change seems to cause the problems: >>>>>> >>>>>> commit 0730d52a86919300a39a2be37f6c140997dfb82f >>>>>> "xhci:prevent "callbacks suppressed" when debug is not enabled" >>>>>> >>>>>> - Sedat - >>>>>> >>>>>> [1] http://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/drivers/usb/host/xhci-ring.c?h=usb-next&id=0730d52a86919300a39a2be37f6c140997dfb82f >>>>>> >>>>> Hello, >>>>> >>>>> [PATCHv2 1/2] was not applied before. >>>>> I pointed this out few hours ago... >> So commit 0730d52a86919300a39a2be37f6c140997dfb82f 'xhci:prevent >> "callbacks suppressed" when debug is not enabled' needed to be applied >> after your first patch? And basically applying that patch alone breaks >> the build? > > Right... > May be I had to stress it somehow... sorry. > Still noone answered me why "drivers/usb/host/xhci-ring.c" does NOT include (dev_info_ratelimited() and other defines). I am expecting that... even I see... drivers/usb/host/.xhci-ring.o.cmd:715: include/linux/device.h \ ...where I don't know why this happens. ( For me this is a bit more important than """trimming""" my responses, I keep the history... ) - Sedat - P.S.: List of includes in xhci-ring.c $ grep ^'#include' -nr drivers/usb/host/xhci-ring.c 67:#include 68:#include 69:#include "xhci.h" 70:#include "xhci-trace.h" >> Ugh. Sorry about this. Greg, how do you want to handle this? >> >> Sarah "needs a vacation" Sharp >> > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/