Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756031Ab3H2ICU (ORCPT ); Thu, 29 Aug 2013 04:02:20 -0400 Received: from mail-wg0-f41.google.com ([74.125.82.41]:65068 "EHLO mail-wg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755641Ab3H2ICP (ORCPT ); Thu, 29 Aug 2013 04:02:15 -0400 MIME-Version: 1.0 Reply-To: sedat.dilek@gmail.com In-Reply-To: <20130828211546.GH26483@xanatos> References: <521DD43D.7070605@samsung.com> <521DD6BD.4030700@samsung.com> <20130828165938.GA26483@xanatos> <521E3259.6040201@samsung.com> <20130828211546.GH26483@xanatos> Date: Thu, 29 Aug 2013 10:02:13 +0200 Message-ID: Subject: Re: linux-next: Tree for Aug 28 [ xhci build breakage ] From: Sedat Dilek To: Sarah Sharp Cc: Dmitry Kasatkin , Greg Kroah-Hartman , Stephen Rothwell , linux-next , LKML , linux-usb@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1944 Lines: 53 On Wed, Aug 28, 2013 at 11:15 PM, Sarah Sharp wrote: > On Wed, Aug 28, 2013 at 07:39:14PM +0200, Sedat Dilek wrote: >> On Wed, Aug 28, 2013 at 7:24 PM, Dmitry Kasatkin wrote: >> Still noone answered me why "drivers/usb/host/xhci-ring.c" does NOT >> include (dev_info_ratelimited() and other defines). >> I am expecting that... even I see... >> >> drivers/usb/host/.xhci-ring.o.cmd:715: include/linux/device.h \ >> >> ...where I don't know why this happens. >> >> ( For me this is a bit more important than """trimming""" my >> responses, I keep the history... ) >> >> - Sedat - >> >> P.S.: List of includes in xhci-ring.c >> >> $ grep ^'#include' -nr drivers/usb/host/xhci-ring.c >> 67:#include >> 68:#include >> 69:#include "xhci.h" >> 70:#include "xhci-trace.h" > > Because a header that xhci-ring.c uses includes device.h instead. > > drivers/usb/host/xhci/xhci-ring.c includes > drivers/usb/host/xhci.h which includes > include/linux/usb.h which includes > include/linux/device.h > > All USB host controllers depend on including usb.h, so I don't think > there's a need for the driver to explicitly include device.h. > Thanks for the explanations. On the one hand it is a fine thingie to place include-files at one single place - think of renamed or moved (uapi) include-files. Looking at xhci-ring.c means for me to dig through 3 or 4 files as someone not dealing everyday with USB stuff. What is the effect of CONFIG_DYNAMIC_DEBUG=[y|n] in the affected code? - Sedat - P.S.: The forgotten patch is now in usb-next, but I don't see any credits, coins, gold, platin... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/