Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S261630AbSJQCEj>; Wed, 16 Oct 2002 22:04:39 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S261635AbSJQCEj>; Wed, 16 Oct 2002 22:04:39 -0400
Received: from orion.netbank.com.br ([200.203.199.90]:53774 "EHLO
	orion.netbank.com.br") by vger.kernel.org with ESMTP
	id <S261630AbSJQCEh>; Wed, 16 Oct 2002 22:04:37 -0400
Date: Wed, 16 Oct 2002 23:10:28 -0300
From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: "David S. Miller" <davem@redhat.com>, neilb@cse.unsw.edu.au,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipv4: make arp seq_file show method only produce one record per call
Message-ID: <20021017021028.GW7541@conectiva.com.br>
Mail-Followup-To: Arnaldo Carvalho de Melo <acme@conectiva.com.br>,
	"David S. Miller" <davem@redhat.com>, neilb@cse.unsw.edu.au,
	linux-kernel@vger.kernel.org
References: <20021017011108.GT7541@conectiva.com.br> <20021016.181550.88499112.davem@redhat.com> <15790.4803.492885.687276@notabene.cse.unsw.edu.au> <20021016.182814.23034875.davem@redhat.com> <20021017020001.GV7541@conectiva.com.br>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20021017020001.GV7541@conectiva.com.br>
User-Agent: Mutt/1.4i
X-Url: http://advogato.org/person/acme
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1346
Lines: 32

Em Wed, Oct 16, 2002 at 11:00:01PM -0300, Arnaldo C. Melo escreveu:
> Em Wed, Oct 16, 2002 at 06:28:14PM -0700, David S. Miller escreveu:
> >    From: Neil Brown <neilb@cse.unsw.edu.au>
> >    Date: Thu, 17 Oct 2002 11:30:43 +1000
> >    
> >    I use seq->private for private state for /proc/fs/nfs/exports.
> >    It works nicely.
> >    You need to define an 'open' the sets it up, and a 'release' to
> >    tear it down, rather than doing it in start/stop.
> >    See fs/nfsd/fnsctl.c:exports_open
> > 
> > Hmmm, Arnaldo? :-)
> 
> 	I know that it works :-) I just refrained from using it because it is
> not the designed purpose for this field, as per what the author stated to me,
> so I didn't wanted to use in a way that could change under my feet in the
> future when Al decided to do some change in seq_file.
> 
> 	But if Al changes his mind and state that this is valid use, great,
> I'll happily use it.
> 
> 	See my other post with Al's comments.

Ok, /me knocks his head on the wall, rereading I think that it is OK, just the
_pointer_ can't change, oh well, duh, back to work.

- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/