Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755814Ab3H2O5t (ORCPT <rfc822;w@1wt.eu>);
	Thu, 29 Aug 2013 10:57:49 -0400
Received: from perceval.ideasonboard.com ([95.142.166.194]:54848 "EHLO
	perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754336Ab3H2O5s (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 29 Aug 2013 10:57:48 -0400
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Chris Ball <cjb@laptop.org>
Cc: Kevin Hilman <khilman@linaro.org>, Lee Jones <lee.jones@linaro.org>,
        Jingoo Han <jg1.han@samsung.com>, Samuel Ortiz <sameo@linux.intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
        Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
        Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH 1/5] mfd: asic3: Remove .set_pwr() callback
Date: Thu, 29 Aug 2013 16:59:11 +0200
Message-ID: <5649106.WzMa2Sr8sS@avalon>
User-Agent: KMail/4.10.5 (Linux/3.8.13-gentoo; KDE/4.10.5; x86_64; ; )
In-Reply-To: <CAGa+x87xcVBxc7_AV8mmGq8DWuhgA3EL6jiwqQD33terH4XPBg@mail.gmail.com>
References: <000301cea3b2$c06f2a20$414d7e60$%han@samsung.com> <81053150.gZpPo7ioCr@avalon> <CAGa+x87xcVBxc7_AV8mmGq8DWuhgA3EL6jiwqQD33terH4XPBg@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2597
Lines: 69

Hi Chris,

On Thursday 29 August 2013 07:42:26 Kevin Hilman wrote:
> On Wed, Aug 28, 2013 at 12:51 AM, Laurent Pinchart wrote:
> > On Wednesday 28 August 2013 08:41:26 Lee Jones wrote:
> >> > > Since 3af9d15 "mmc: tmio-mmc: Remove .set_pwr() callback from
> >> > > platform data", .set_pwr() callback is removed from platform data.
> >> > > Thus, .set_pwr() is not used anymore. Also, this patch fixes
> >> > > the following build error and warning.
> >> > > 
> >> > > drivers/mfd/asic3.c:724:2: error: unknown field 'set_pwr' specified
> >> > > in initializer drivers/mfd/asic3.c:724:2: warning: initialization
> >> > > makes integer from pointer without a cast [enabled by default]
> >> > > drivers/mfd/asic3.c:724:2: warning: (near initialization for
> >> > > 'asic3_mmc_data.capabilities' [enabled by default]
> >> > 
> >> > My bad, it looks like I've overlooked a few users of the .set_pwr()
> >> > field
> >> > 
> >> > :-/ Sorry about that.
> >> 
> >> <snip>
> >> 
> >> > I don't think blindly removing the function is the right fix, as it
> >> > seems to be needed. Looking at the whole series, I believe we should
> >> > just revert 3af9d15 "mmc: tmio-mmc: Remove .set_pwr() callback from
> >> > platform data" instead.
> >> 
> >> No need to revert it, as it's not in Mainline yet. Just request for it
> >> to be removed from Chris' tree.
> > 
> > I spupose it depends on whether Chris has provided a stable branch with
> > the patch included. I'm fine with both, the commit just needs to be undone
> > one way or another.
> 
> Any progress on this?  linux-next builds are still failing for the
> following defconfigs because of this removal:

Chris, could you please drop 3af9d15 "mmc: tmio-mmc: Remove .set_pwr() 
callback from platform data" from your tree or revert it ?

> Failed defconfigs:
>         arm-magician_defconfig
>         arm-eseries_pxa_defconfig
> 
> Errors:
> 
>          arm-magician_defconfig
> drivers/mfd/asic3.c:724:2: error: unknown field 'set_pwr' specified in
> initializer
> 
>         arm-eseries_pxa_defconfig
> drivers/mfd/t7l66xb.c:146:2: error: unknown field 'set_pwr' specified
> in initializer
> drivers/mfd/tc6387xb.c:123:2: error: unknown field 'set_pwr' specified
> in initializer
> drivers/mfd/tc6393xb.c:381:2: error: unknown field 'set_pwr' specified
> in initializer

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/