Message-ID: <521F8ED4.2080009@zytor.com>
Date: Thu, 29 Aug 2013 11:11:32 -0700
From: "H. Peter Anvin" <hpa@zytor.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
MIME-Version: 1.0
To: =?ISO-8859-1?Q?Jan-Simon_M=F6ller?= <dl9pf@gmx.de>
CC: llvmlinux@lists.linuxfoundation.org, pageexec@freemail.hu, x86@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [llvmlinux] [PATCH] [RFC] [X86] Fix a compilation issue with
 clang.
References: <1377796428-12719-1-git-send-email-dl9pf@gmx.de> <521F84D4.6060108@zytor.com> <6320951.e8eKRZ5b9s@aragorn.auenland.lan>
In-Reply-To: <6320951.e8eKRZ5b9s@aragorn.auenland.lan>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 900
Lines: 24

On 08/29/2013 11:00 AM, Jan-Simon M?ller wrote:
>>
>> You just changed the sematics of the _ASM_* macros... that doesn't seem
>> like a great idea.  It's probably okay for the registers, but still...
> 
> Well, we followed your idea for the _ASM_DX macros as you mentioned them 
> earlier.
> 

We can probably do this, because register names are usually not assumed
to have spaces around them... so it's probably okay.  Definitely a lot
less ugly than the rest.  That being said, if we're going to fix these
macros, we should also fix another piece of drain bramage:

ALL instances of these have a % prepended.  The % should be part of the
macro.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/