Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756676Ab3H2Tim (ORCPT ); Thu, 29 Aug 2013 15:38:42 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:49789 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755751Ab3H2Til (ORCPT ); Thu, 29 Aug 2013 15:38:41 -0400 Message-ID: <521FA335.2060309@ti.com> Date: Thu, 29 Aug 2013 15:38:29 -0400 From: Eduardo Valentin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Durgadoss R CC: , , , , , Subject: Re: [PATCHv3 0/8] Thermal Framework Enhancements References: <1360061183-14137-1-git-send-email-durgadoss.r@intel.com> In-Reply-To: <1360061183-14137-1-git-send-email-durgadoss.r@intel.com> X-Enigmail-Version: 1.5.2 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7EVLd3EG5DW1Rsg2N2RReabD59tV7aob1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4629 Lines: 114 --7EVLd3EG5DW1Rsg2N2RReabD59tV7aob1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Durga, On 05-02-2013 06:46, Durgadoss R wrote: > This patch set is a v3 of the previous versions submitted here: > [v2]: http://lwn.net/Articles/531720/ > [v1]: https://lkml.org/lkml/2012/12/18/108=20 > [RFC]:https://patchwork.kernel.org/patch/1758921/ >=20 Long time this work is not moving forward. While writing the device tree parser, I thought of using your work as baseline to see how the multiple sensor per zone would look like (also in DT). But while checking your code again, I realized that you are actually creating a new API, that is probably why you named it sysfs-api2. While I understand the motivation (they are pretty different), I believe this is not a good thing to do. I would suggest making so that we have a single API. > This patch set is based on Rui's -next tree, and is > tested on a Core-i5 and an Atom netbook. >=20 > Changes since v2: > * Reworked the map sysfs attributes in patch [5/8] > * Dropped configuration for maximum sensors and > cooling devices, through Kconfig. > * Added __remove_trip_attr method > * Renamed __clean_map_entry to __remove_map_entry > for consistency in naming. > Changes Since v1: > * Removed kobject creation for thermal_trip and thermal_map > nodes as per Greg-KH's comments. > * Added ABI Documentation under 'testing'. > * Modified the GET_INDEX macro to be more linux-like, thanks > to Joe Perches. > * Added get_[sensor/cdev]_by_name APIs to thermal.h >=20 > This series contains 8 patches: > Patch 1/8: Creates new sensor level APIs > Patch 2/8: Creates new zone level APIs. The existing tzd structure is > kept as such for clarity and compatibility purposes. > Patch 3/8: Creates functions to add/remove a cdev to/from a zone. The > existing tcd structure need not be modified. > Patch 4/8: Adds sensorX_trip_[active/passive/hot/critical] sysfs nodes,= > under /sys/class/thermal/zoneY/. This exposes various trip > points for sensorX present in zoneY. > Patch 5/8: Adds mapY_* sysfs node. These attributes represent > the binding relationship between a sensor and a cdev, > within a zone. > Patch 6/8: Creates Documentation for the new APIs. A new file is > created for clarity. Final goal is to merge with the existin= g > file or refactor the files, as whatever seems appropriate. > Patch 7/8: Add ABI documentation for sysfs interfaces introduced in thi= s patch. > Patch 8/8: A dummy driver that can be used for testing. This is not for= merge. >=20 > Durgadoss R (8): > Thermal: Create sensor level APIs > Thermal: Create zone level APIs > Thermal: Add APIs to bind cdev to new zone structure > Thermal: Add trip point sysfs nodes for sensor > Thermal: Create Thermal map sysfs attributes for a zone > Thermal: Add Documentation to new APIs > Thermal: Add ABI Documentation for sysfs interfaces > Thermal: Dummy driver used for testing >=20 > Documentation/ABI/testing/sysfs-class-thermal | 137 ++++ > Documentation/thermal/sysfs-api2.txt | 247 ++++++ > drivers/thermal/Kconfig | 5 + > drivers/thermal/Makefile | 2 + > drivers/thermal/thermal_sys.c | 994 +++++++++++++++++= ++++++++ > drivers/thermal/thermal_test.c | 324 ++++++++ > include/linux/thermal.h | 123 ++- > 7 files changed, 1831 insertions(+), 1 deletion(-) > create mode 100644 Documentation/ABI/testing/sysfs-class-thermal > create mode 100644 Documentation/thermal/sysfs-api2.txt > create mode 100644 drivers/thermal/thermal_test.c >=20 --=20 You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin --7EVLd3EG5DW1Rsg2N2RReabD59tV7aob1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iF4EAREIAAYFAlIfozgACgkQCXcVR3XQvP29JgEA9QA9MaJrspvD2XKhbjAE4X50 tNjQLNu4mQeOFGtWTUwA/jyX7ayA+T0yiCRJ21xUMSc0Znf8hYS1rNxv1+fXz+ap =FpNV -----END PGP SIGNATURE----- --7EVLd3EG5DW1Rsg2N2RReabD59tV7aob1-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/