Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754320Ab3H3Iaq (ORCPT ); Fri, 30 Aug 2013 04:30:46 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:53092 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752728Ab3H3Ian (ORCPT ); Fri, 30 Aug 2013 04:30:43 -0400 Message-ID: <522057DA.2000009@huawei.com> Date: Fri, 30 Aug 2013 16:29:14 +0800 From: Jianguo Wu User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Michal Hocko CC: Andrew Morton , Li Zefan , Johannes Weiner , , , , , , , Wen Congyang Subject: Re: [PATCH 5/5] mm/cgroup: use N_MEMORY instead of N_HIGH_MEMORY References: <52201539.8050003@huawei.com> <20130830074152.GA28658@dhcp22.suse.cz> In-Reply-To: <20130830074152.GA28658@dhcp22.suse.cz> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.135.74.216] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2713 Lines: 83 On 2013/8/30 15:41, Michal Hocko wrote: > On Fri 30-08-13 11:44:57, Jianguo Wu wrote: >> Since commit 8219fc48a(mm: node_states: introduce N_MEMORY), > > But this very same commit also says: > " > A.example 2) mm/page_cgroup.c use N_HIGH_MEMORY twice: > > One is in page_cgroup_init(void): > for_each_node_state(nid, N_HIGH_MEMORY) { > > It means if the node have memory, we will allocate page_cgroup map for > the node. We should use N_MEMORY instead here to gaim more clearly. > > The second using is in alloc_page_cgroup(): > if (node_state(nid, N_HIGH_MEMORY)) > addr = vzalloc_node(size, nid); > > It means if the node has high or normal memory that can be allocated > from kernel. We should keep N_HIGH_MEMORY here, and it will be better > if the "any memory" semantic of N_HIGH_MEMORY is removed. > " > > Which to me sounds like N_HIGH_MEMORY should be kept here. To be honest, Hi Michal, You are right, here we need normal or high memory, but not movable memory, so N_HIGH_MEMORY should be kept here, the same as other patches, please drop this series. Thank you for your point out. Thanks, Jianguo Wu. > the distinction is not entirely clear to me. It was supposed to make > code cleaner but it apparently causes confusion. > > It would also help if you CCed Lai Jiangshan who has introduced this > distinction. CCed now. > > I wasn't CCed on the rest of the series but if you do the same > conversion, please make sure that this is not the case for others as > well. > >> we introduced N_MEMORY, now N_MEMORY stands for the nodes that has any memory, >> and N_HIGH_MEMORY stands for the nodes that has normal or high memory. >> >> The code here need to handle with the nodes which have memory, >> we should use N_MEMORY instead. >> >> Signed-off-by: Xishi Qiu >> --- >> mm/page_cgroup.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/mm/page_cgroup.c b/mm/page_cgroup.c >> index 6d757e3..f6f7603 100644 >> --- a/mm/page_cgroup.c >> +++ b/mm/page_cgroup.c >> @@ -116,7 +116,7 @@ static void *__meminit alloc_page_cgroup(size_t size, int nid) >> return addr; >> } >> >> - if (node_state(nid, N_HIGH_MEMORY)) >> + if (node_state(nid, N_MEMORY)) >> addr = vzalloc_node(size, nid); >> else >> addr = vzalloc(size); >> -- >> 1.7.1 >> >> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/