Date: Fri, 30 Aug 2013 14:30:57 +0200
From: Samuel Ortiz <sameo@linux.intel.com>
To: Chao Xie <xiechao.mail@gmail.com>
Cc: Chao Xie <chao.xie@marvell.com>, Lee Jones <lee.jones@linaro.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] mfd: 88pm800: Fix the bug that pdata may be NULL
Message-ID: <20130830123057.GK20329@zurbaran>
References: <1376875675-11286-1-git-send-email-chao.xie@marvell.com>
 <1376875675-11286-2-git-send-email-chao.xie@marvell.com>
 <20130820014042.GF13324@zurbaran>
 <CADApbehFDH2-vJMHuVPq8i+zR0fm4ii36JNB_CEKaYEx0r23zw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CADApbehFDH2-vJMHuVPq8i+zR0fm4ii36JNB_CEKaYEx0r23zw@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1042
Lines: 32

Hi Xie,

On Tue, Aug 27, 2013 at 02:11:58PM +0800, Chao Xie wrote:
> On Tue, Aug 20, 2013 at 9:40 AM, Samuel Ortiz <sameo@linux.intel.com> wrote:
> > Hi Xie,
> >
> > On Sun, Aug 18, 2013 at 09:27:54PM -0400, Chao Xie wrote:
> >> User pass platform data to device, and platform data may be
> >> NULL.
> > In which case do you get that ? With DT ?
> > Should rtc_init fail when pdata is NULL ?
> >
> > You need to explain that, be it only for us to know if it's a critical
> > fix or not.
> >
> Sorry for late response.
> If pdata is NULL, the driver will fail. 
The question is: Why would pdata be NULL ? If there's a fundamental
issue you're hiding with this patch, you probably want to fix the real
problem instead.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/