Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756576Ab3H3OQW (ORCPT ); Fri, 30 Aug 2013 10:16:22 -0400 Received: from mail-ve0-f176.google.com ([209.85.128.176]:46770 "EHLO mail-ve0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755945Ab3H3OQV (ORCPT ); Fri, 30 Aug 2013 10:16:21 -0400 MIME-Version: 1.0 In-Reply-To: References: <1376090777-20090-1-git-send-email-roy.franz@linaro.org> <1376090777-20090-15-git-send-email-roy.franz@linaro.org> <20130830134325.51DC83E102A@localhost> <20130830134754.GX6617@n2100.arm.linux.org.uk> Date: Fri, 30 Aug 2013 07:16:20 -0700 Message-ID: Subject: Re: [PATCH 14/16] Add strstr to compressed string.c for ARM. From: Roy Franz To: Grant Likely Cc: Russell King - ARM Linux , Linux Kernel Mailing List , linux-efi@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , matt.fleming@intel.com, Leif Lindholm , Dave P Martin , Mark Salter Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1315 Lines: 32 On Fri, Aug 30, 2013 at 7:02 AM, Grant Likely wrote: > On Fri, Aug 30, 2013 at 2:47 PM, Russell King - ARM Linux > wrote: >> On Fri, Aug 30, 2013 at 02:43:25PM +0100, Grant Likely wrote: >>> On Fri, 9 Aug 2013 16:26:15 -0700, Roy Franz wrote: >>> > The shared efi-stub-helper.c functions require a strstr >>> > implementation. >>> > Implementation copied from arch/x86/boot/string.c >>> > >>> > Signed-off-by: Roy Franz >>> >>> Okay, but at some point arch/arm/boot/compressed/string.c should be >>> reworked into a common place. >> >> Only if the common place can be built with arch specific compile options, >> like -fpic, without impacting the rest of the kernel. > > agreed. It would be a bit of a science project to see how feasible. > > g. The strstr implemtation here is pretty generic, but some architectures like x86 use inline ASM for some of these string functions, so there are some additional complications to unifying this code across architectures. Roy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/