Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756868Ab3H3XF5 (ORCPT ); Fri, 30 Aug 2013 19:05:57 -0400 Received: from mga11.intel.com ([192.55.52.93]:6210 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753853Ab3H3XF4 convert rfc822-to-8bit (ORCPT ); Fri, 30 Aug 2013 19:05:56 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.89,994,1367996400"; d="scan'208";a="394737423" From: "Luck, Tony" To: Kees Cook , Maxime Bizon CC: Anton Vorontsov , Colin Cross , LKML Subject: RE: [PATCH] pstore/ram: (really) fix undefined usage of rounddown_pow_of_two Thread-Topic: [PATCH] pstore/ram: (really) fix undefined usage of rounddown_pow_of_two Thread-Index: AQHOpZsFV70POy9UR0iXLYLxNNNMtZmuhAuA///bbPA= Date: Fri, 30 Aug 2013 23:05:54 +0000 Message-ID: <3908561D78D1C84285E8C5FCA982C28F31CD4884@ORSMSX106.amr.corp.intel.com> References: <1377878801.559.28.camel@sakura.staff.proxad.net> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 584 Lines: 19 >> Previous attempt to fix was b042e47491ba5f487601b5141a3f1d8582304170 >> >> Suggested use of is_power_of_2() was bogus because is_power_of_2(0) is >> false (documented behaviour). >> >> Signed-off-by: Maxime Bizon > > Yes, excellent point. :) > > Acked-by: Kees Cook Applied. Thanks. -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/