Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756637Ab3H3XOp (ORCPT ); Fri, 30 Aug 2013 19:14:45 -0400 Received: from mail-qc0-f181.google.com ([209.85.216.181]:58687 "EHLO mail-qc0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753023Ab3H3XOn (ORCPT ); Fri, 30 Aug 2013 19:14:43 -0400 MIME-Version: 1.0 In-Reply-To: References: <1376090777-20090-1-git-send-email-roy.franz@linaro.org> <1376090777-20090-13-git-send-email-roy.franz@linaro.org> <20130830133902.AEA7A3E102A@localhost> From: Grant Likely Date: Sat, 31 Aug 2013 00:14:22 +0100 X-Google-Sender-Auth: Ig2C0QPVPd7w-y9cjtUKtX8Cn8k Message-ID: Subject: Re: [PATCH 12/16] Fix types in EFI calls to match EFI function definitions. To: Roy Franz Cc: matt.fleming@intel.com, Linux Kernel Mailing List , linux-efi@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , Russell King - ARM Linux , Leif Lindholm , Dave Martin , Mark Salter Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1192 Lines: 27 On Sat, Aug 31, 2013 at 12:12 AM, Roy Franz wrote: > On Fri, Aug 30, 2013 at 6:39 AM, Grant Likely wrote: >> I think you need some description in the commit text about why the type >> of chunksize is changing. It's not clear why you're making this change. >> It is a bug fix? > > The type was changed to match the EFI_FILE_PROTOCOL specification - > chunk size is > defined as a native width unsigned integer. So yes, this is a bug in > that this is wrong for > ia32, since that really should be a u32 in that case. > Since the x86 wrappers break type checking by the compiler these types > were never checked at compile time > before. chunksize is the the only change that isn't a cast to a type > of void pointer. > > I can break this change out as a separate patch if desired. I don't think it needs to be in a separate patch, but it does need to be described in the patch description. g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/