Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757191Ab3HaGp4 (ORCPT ); Sat, 31 Aug 2013 02:45:56 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:34238 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757088Ab3HaGps (ORCPT ); Sat, 31 Aug 2013 02:45:48 -0400 Message-ID: <522190F1.3010103@huawei.com> Date: Sat, 31 Aug 2013 14:45:05 +0800 From: Libo Chen User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: CC: Bill Pemberton , , , , , LKML , Li Zefan , "zhangwei(Jovi)" Subject: [PATCH 3/3] driver: input: twl6040-vibra: fix missing of_node_put Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.135.72.158] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1520 Lines: 46 decrease twl6040_core_node device_node refcount after task completion There are two ways to implement the function of_node_put through the marco CONFIG_OF_DYNAMIC, so it is save to call directly. Signed-off-by: Libo Chen --- drivers/input/misc/twl6040-vibra.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/input/misc/twl6040-vibra.c b/drivers/input/misc/twl6040-vibra.c index 0c2dfc8..f16193a 100644 --- a/drivers/input/misc/twl6040-vibra.c +++ b/drivers/input/misc/twl6040-vibra.c @@ -271,12 +271,14 @@ static int twl6040_vibra_probe(struct platform_device *pdev) #endif if (!pdata && !twl6040_core_node) { + of_node_put(twl6040_core_node); dev_err(&pdev->dev, "platform_data not available\n"); return -EINVAL; } info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL); if (!info) { + of_node_put(twl6040_core_node); dev_err(&pdev->dev, "couldn't allocate memory\n"); return -ENOMEM; } @@ -304,6 +306,7 @@ static int twl6040_vibra_probe(struct platform_device *pdev) &vddvibl_uV); of_property_read_u32(twl6040_core_node, "ti,vddvibr-uV", &vddvibr_uV); + of_node_put(twl6040_core_node); } if ((!info->vibldrv_res && !info->viblmotor_res) || -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/