Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756960Ab3HaTsT (ORCPT ); Sat, 31 Aug 2013 15:48:19 -0400 Received: from icebox.esperi.org.uk ([81.187.191.129]:54461 "EHLO mail.esperi.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753569Ab3HaTsR (ORCPT ); Sat, 31 Aug 2013 15:48:17 -0400 From: Nix To: Greg KH Cc: Bernd Schubert , "Martin K. Petersen" , Linux Kernel Mailing List , linux-scsi@vger.kernel.org, nick.cheng@areca.com.tw, stable@vger.kernel.org, Douglas Gilbert , "James E.J. Bottomley" Subject: Re: [PATCH] scsi disk: Use its own buffer for the vpd request References: <87mwp5frdl.fsf@spindle.srvr.nix> <51F67959.2060803@fastmail.fm> <87fvuxdqes.fsf@spindle.srvr.nix> <51F80167.1080004@fastmail.fm> <51F94E8D.5040908@fastmail.fm> <51F95A2E.60805@fastmail.fm> <51FA71E2.6010501@fastmail.fm> <871u5b7azv.fsf@spindle.srvr.nix> <20130831015337.GA8164@kroah.com> Emacs: because extension languages should come with the editor built in. Date: Sat, 31 Aug 2013 20:48:00 +0100 In-Reply-To: <20130831015337.GA8164@kroah.com> (Greg KH's message of "Fri, 30 Aug 2013 18:53:37 -0700") Message-ID: <87d2ot1w27.fsf@spindle.srvr.nix> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-DCC-wuwien-Metrics: spindle 1290; Body=9 Fuz1=9 Fuz2=9 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1654 Lines: 44 On 31 Aug 2013, Greg KH said: > On Fri, Aug 30, 2013 at 11:01:56AM +0100, Nix wrote: >> On 1 Aug 2013, Bernd Schubert said: >> >> > Once I noticed that scsi_get_vpd_page() works fine from other function >> > calls and that it is not 0x89, but already 0x0 that fails fixing it became >> > easy. >> > >> > Nix, any chance you could verify it also works for you? >> >> As an aside, this commit does indeed fix the bug I reported, but it >> doesn't seem to have gone anywhere, not even into -stable. >> >> Is it held up somehow? >> >> (stable has >> >> commit 0ac10bd036f0f3b8ce7ac2390446eab9531c72eb >> Author: Martin K. Petersen >> Date: Tue Jul 30 22:58:34 2013 -0400 >> >> SCSI: Don't attempt to send extended INQUIRY command if skip_vpd_pages is set >> >> which IIRC was eventually found not to be necessary, because this fix >> works fine instead?) >> >> Possibly I'm misremembering the order of month-old events and Martin's >> fix was eventually considered better... in which case, sorry for the noise. > > Is that other patch even needed anymore, now that Martin's patch is in > the tree? My understanding is that this patch is rather better, since Martin's patch prevents sending of the extended INQUIRY command at all: this one just uses a reduced buffer size, but can still issue the command. (But I may be misunderstanding everything.) -- NULL && (void) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/