Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756126Ab3HaWte (ORCPT ); Sat, 31 Aug 2013 18:49:34 -0400 Received: from mail-vc0-f172.google.com ([209.85.220.172]:35037 "EHLO mail-vc0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753181Ab3HaWtc (ORCPT ); Sat, 31 Aug 2013 18:49:32 -0400 MIME-Version: 1.0 In-Reply-To: <20130831212355.GN13318@ZenIV.linux.org.uk> References: <5220E56A.80603@hp.com> <5220F090.5050908@hp.com> <5220FD51.2010709@hp.com> <20130830205404.GF13318@ZenIV.linux.org.uk> <20130830214452.GH13318@ZenIV.linux.org.uk> <20130831212355.GN13318@ZenIV.linux.org.uk> Date: Sat, 31 Aug 2013 15:49:31 -0700 X-Google-Sender-Auth: EYiiN_1K1n46-xLukx-iLR9WB-w Message-ID: Subject: Re: [PATCH v7 1/4] spinlock: A new lockref structure for lockless update of refcount From: Linus Torvalds To: Al Viro Cc: Waiman Long , Ingo Molnar , Benjamin Herrenschmidt , Jeff Layton , Miklos Szeredi , Ingo Molnar , Thomas Gleixner , linux-fsdevel , Linux Kernel Mailing List , Peter Zijlstra , Steven Rostedt , Andi Kleen , "Chandramouleeswaran, Aswin" , "Norton, Scott J" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1052 Lines: 25 On Sat, Aug 31, 2013 at 2:23 PM, Al Viro wrote: > > Hmm... OK, most of these suckers are actually doing just one component; > we can look into 'print the ancestors as well' later, but the minimal > variant would be something like this and it already covers a lot of those > guys. Comments? Doesn't look wrong, but remember the /proc debugging thing? We definitely wanted more than just one pathname component, and I don't think that's completely rare. So I think it would be better to prepare for that, and simply print to a local buffer, and then use the "string()" function on the end result. Rather than do it directly from the dentry like you do, and then having to do that widen() thing because you couldn't do the strnlen() that that code wanted.. Hmm? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/