Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757107Ab3IABAg (ORCPT ); Sat, 31 Aug 2013 21:00:36 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:50344 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752364Ab3IABAe (ORCPT ); Sat, 31 Aug 2013 21:00:34 -0400 X-Sasl-enc: GUCHoq2tlBx7xeQyKpGx0ivYp4j720jYIKDa48mgKDME 1377997232 Message-ID: <1377997229.4223.9.camel@perseus.fritz.box> Subject: Re: [PATCH 0/9] [RFC v2] safely drop directory dentry on failed revalidate From: Ian Kent To: Miklos Szeredi Cc: Miklos Szeredi , Al Viro , Ric Wheeler , Anand Avati , Brian Foster , David Howells , Eric Paris , Linux-Fsdevel , Kernel Mailing List , KONISHI Ryusuke Date: Sun, 01 Sep 2013 09:00:29 +0800 In-Reply-To: <1377996985.4223.6.camel@perseus.fritz.box> References: <1375975490-18673-1-git-send-email-miklos@szeredi.hu> <20130821054055.GN27005@ZenIV.linux.org.uk> <1377748272.9297.47.camel@tucsk.piliscsaba.szeredi.hu> <1377818677.2355.25.camel@perseus.fritz.box> <1377819852.2355.28.camel@perseus.fritz.box> <1377996985.4223.6.camel@perseus.fritz.box> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.4 (3.6.4-3.fc18) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1408 Lines: 37 On Sun, 2013-09-01 at 08:56 +0800, Ian Kent wrote: > On Fri, 2013-08-30 at 10:59 +0200, Miklos Szeredi wrote: > > On Fri, Aug 30, 2013 at 1:44 AM, Ian Kent wrote: > > > > >> The check in waitq.c above "is" used to validate the need to callback to > > >> the daemon to request a mount. > > > > Okay. But then shouldn't the check be "if (d_mountpoint(dentry)) valid = 0;" ? > > I don't think so. > > But again, may_umount() might do what's needed here too. Oh, hang on, may_umount() can't be used for the root-less multi-mount case at all, since there's no vfsmount at the base of the tree the check can't be restricted to just the tree of subdirs that needs to be checked. That's been a problem for me for a long time. > > I don't think this is enough because it doesn't cover the case where the > dentry is not simple_empty() but has no mounts below. That's not a > normal use case but could happen if the daemon crashed at just the wrong > time, encountered an error condition that didn't allow it to cleanup > directories, or a user umounted triggers within the tree before starting > the daemon. > > > > > Thanks, > > Miklos > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/