Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757714Ab3IARBb (ORCPT ); Sun, 1 Sep 2013 13:01:31 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:54299 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755822Ab3IARB3 (ORCPT ); Sun, 1 Sep 2013 13:01:29 -0400 Message-ID: <522372EB.1060701@ti.com> Date: Sun, 1 Sep 2013 20:01:31 +0300 From: Peter Ujfalusi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130808 Thunderbird/17.0.8 MIME-Version: 1.0 To: Libo Chen CC: , Bill Pemberton , , , LKML Subject: Re: [PATCH 2/3] driver: input: twl4030-vibra: fix missing of_node_put References: <522190ED.6020909@huawei.com> In-Reply-To: <522190ED.6020909@huawei.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1100 Lines: 38 On 08/31/2013 09:45 AM, Libo Chen wrote: > > decrease node device_node refcount after task completion > > Signed-off-by: Libo Chen Acked-by: Peter Ujfalusi > --- > drivers/input/misc/twl4030-vibra.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/drivers/input/misc/twl4030-vibra.c b/drivers/input/misc/twl4030-vibra.c > index 68a5f33..b8d1526 100644 > --- a/drivers/input/misc/twl4030-vibra.c > +++ b/drivers/input/misc/twl4030-vibra.c > @@ -185,8 +185,10 @@ static bool twl4030_vibra_check_coexist(struct twl4030_vibra_data *pdata, > if (pdata && pdata->coexist) > return true; > > - if (of_find_node_by_name(node, "codec")) > + if (of_find_node_by_name(node, "codec")) { > + of_node_put(node); > return true; > + } > > return false; > } > -- P?ter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/