Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755207Ab3IBBUw (ORCPT ); Sun, 1 Sep 2013 21:20:52 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:39299 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753003Ab3IBBUu (ORCPT ); Sun, 1 Sep 2013 21:20:50 -0400 Date: Sun, 01 Sep 2013 18:20:48 -0700 (PDT) Message-ID: <87ppssrpci.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: George Cherian Cc: linus.walleij@linaro.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, n.a.balandin@gmail.com Subject: Re: [PATCH v2 1/3] gpio: pcf857x: change to devm_request_threaded_irq In-Reply-To: <1377859713-13460-2-git-send-email-george.cherian@ti.com> References: <1377859713-13460-1-git-send-email-george.cherian@ti.com> <1377859713-13460-2-git-send-email-george.cherian@ti.com> User-Agent: Wanderlust/2.14.0 Emacs/23.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1218 Lines: 39 Hi > Remove the request_irq and use devm_request_threaded_irq > also cleanup free_irq. devm_* takes care of that. > > Signed-off-by: George Cherian > --- > arch/arm/boot/dts/dra7-evm.dts | 2 +- > drivers/gpio/gpio-pcf857x.c | 28 ++++++++++++++++++++++++---- > 2 files changed, 25 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts > index 8b0738a..39b44bc 100644 > --- a/arch/arm/boot/dts/dra7-evm.dts > +++ b/arch/arm/boot/dts/dra7-evm.dts > @@ -65,7 +65,7 @@ > n_latch = <0x1408>; > gpio-controller; > #gpio-cells = <2>; > - interrupt-parent = <&pcf_20>; > + interrupt-parent = <&gpio20>; > interrupts = <14 2>; > interrupt-controller; > #interrupt-cells = <2>; I'm not sure detail, but does above "exchange interrupt-parent" and "using devm_request_threaded_irq()" have any relationship ? Separate patch seems nice ? Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/