Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753877Ab3IBEsi (ORCPT ); Mon, 2 Sep 2013 00:48:38 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:61822 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752266Ab3IBEsg (ORCPT ); Mon, 2 Sep 2013 00:48:36 -0400 Message-ID: <522418A2.8030909@gmail.com> Date: Sun, 01 Sep 2013 23:48:34 -0500 From: Ian Pilcher User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 MIME-Version: 1.0 To: linux-leds@vger.kernel.org, kernelnewbies@kernelnewbies.org, linux-kernel@vger.kernel.org Subject: Re: device_create_file returns 0 but doesn't work References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1419 Lines: 34 On 09/01/2013 06:38 PM, Ian Pilcher wrote: > I am trying to add an additional sysfs attribute to a device (LED) that > is created by another driver. (My ultimate goal is to provide a way for > a userspace application to use the functionality provided by > led_blink_set, which doesn't currently seem to be possible.) Turns out it is possible, with the LED timer trigger, so this issue is now moot. > > The kernel module code that sets up all the GPIOs & LEDs in my NAS is > at: > > http://pastebin.com/TJZGww8T > > The call to device_create_file is at line 373. > > device_create_file is returning 0, but the "foo" attribute is not being > created. ("find /sys -name '*foo*'" doesn't find anything, so I'm not > just looking in the wrong place.) Still rather odd that it doesn't work, however, since ledtrig-timer.c seems to do pretty much the same thing. Oh well. -- ======================================================================== Ian Pilcher arequipeno@gmail.com Sometimes there's nothing left to do but crash and burn...or die trying. ======================================================================== -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/