Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757379Ab3IBGzE (ORCPT ); Mon, 2 Sep 2013 02:55:04 -0400 Received: from mail-pb0-f54.google.com ([209.85.160.54]:48070 "EHLO mail-pb0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755613Ab3IBGzC (ORCPT ); Mon, 2 Sep 2013 02:55:02 -0400 Date: Sun, 01 Sep 2013 23:55:00 -0700 (PDT) Message-ID: <87a9jvsofz.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: George Cherian Cc: linus.walleij@linaro.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, n.a.balandin@gmail.com Subject: Re: [PATCH v3 0/3] cleanup of gpio_pcf857x.c In-Reply-To: <1378089004-14478-1-git-send-email-george.cherian@ti.com> References: <1378089004-14478-1-git-send-email-george.cherian@ti.com> User-Agent: Wanderlust/2.14.0 Emacs/23.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1145 Lines: 39 Hi Sorry for my many response. > This patch series > - removes the irq_demux_work > - Uses devm_request_threaded_irq > - Call the user handler iff gpio_to_irq is done. > > v1 --> v2 > Split v1 to 3 patches > v2 --> v3 > Remove the unnecessary dts patches. > > > George Cherian (3): > gpio: pcf857x: change to devm_request_threaded_irq > gpio: pcf857x: remove the irq_demux_work > gpio: pcf857x: call the gpio user handler iff gpio_to_irq is done > > drivers/gpio/gpio-pcf857x.c | 51 +++++++++++++++++++++++---------------------- > 1 file changed, 26 insertions(+), 25 deletions(-) Basically, I have no objection about these patches, but I have 2 opinions - I guess we can merge #1 and #2 patches ? ("as is" is very OK for me though) - we don't need gpio->irq any more ? (additional patch is very OK for me) Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/