Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758145Ab3IBHPb (ORCPT ); Mon, 2 Sep 2013 03:15:31 -0400 Received: from cm-84.215.157.11.getinternet.no ([84.215.157.11]:58914 "EHLO server.arpanet.local" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755708Ab3IBHPa (ORCPT ); Mon, 2 Sep 2013 03:15:30 -0400 Date: Mon, 2 Sep 2013 08:56:37 +0200 From: Jon Arne =?utf-8?Q?J=C3=B8rgensen?= To: Wang Shilong Cc: Jon Arne =?utf-8?Q?J=C3=B8rgensen?= , linux-kernel@vger.kernel.org, lkundrak@v3.sk, mkrufky@linuxtv.org, hans.verkuil@cisco.com, rdunlap@infradead.org Subject: Re: [RFC,v3] Add a driver for the Somagic smi2021 chip Message-ID: <20130902065637.GA22726@server.arpanet.local> References: <52239a76.XU34CEethg4oyQtW%wangshilong1991@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52239a76.XU34CEethg4oyQtW%wangshilong1991@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1078 Lines: 28 On Mon, Sep 02, 2013 at 03:50:14AM +0800, Wang Shilong wrote: Hi, > Hello, Using checkpatch.pl, i get the following warnings(errors): > WARNING: Avoid CamelCase: descriptor.idProduct> > #1766: FILE: drivers/media/usb/smi2021/smi2021_main.c:790: > + if (udev->descriptor.idProduct == BOOTLOADER_ID) > > total: 0 errors, 1 warnings, 2110 lines checked > > patch has style problems, please review. > That problem lies within the usb-subsystem. When I ran checkpatch.pl on the patch before submitting this didn't show up. Are you using an old version of checkpatch.pl? > If any of these errors are false positives, please report > them to the maintainer, see CHECKPATCH in MAINTAINERS. > > Thanks, Wang > > Notice: this is an automatically generated by shell script > Any problems please contact: wangshilong1991@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/