Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757529Ab3IBIuR (ORCPT ); Mon, 2 Sep 2013 04:50:17 -0400 Received: from mga03.intel.com ([143.182.124.21]:39996 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755055Ab3IBIuP (ORCPT ); Mon, 2 Sep 2013 04:50:15 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.89,1005,1367996400"; d="scan'208";a="354757399" Date: Mon, 2 Sep 2013 10:50:10 +0200 From: Samuel Ortiz To: Chao Xie Cc: Chao Xie , Lee Jones , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/2] mfd: 88pm800: Fix the bug that pdata may be NULL Message-ID: <20130902085010.GO20329@zurbaran> References: <1376875675-11286-1-git-send-email-chao.xie@marvell.com> <1376875675-11286-2-git-send-email-chao.xie@marvell.com> <20130820014042.GF13324@zurbaran> <20130830123057.GK20329@zurbaran> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1455 Lines: 41 Hi Chao, On Mon, Sep 02, 2013 at 09:21:04AM +0800, Chao Xie wrote: > On Fri, Aug 30, 2013 at 8:30 PM, Samuel Ortiz wrote: > > Hi Xie, > > > > On Tue, Aug 27, 2013 at 02:11:58PM +0800, Chao Xie wrote: > >> On Tue, Aug 20, 2013 at 9:40 AM, Samuel Ortiz wrote: > >> > Hi Xie, > >> > > >> > On Sun, Aug 18, 2013 at 09:27:54PM -0400, Chao Xie wrote: > >> >> User pass platform data to device, and platform data may be > >> >> NULL. > >> > In which case do you get that ? With DT ? > >> > Should rtc_init fail when pdata is NULL ? > >> > > >> > You need to explain that, be it only for us to know if it's a critical > >> > fix or not. > >> > > >> Sorry for late response. > >> If pdata is NULL, the driver will fail. > > The question is: Why would pdata be NULL ? If there's a fundamental > > issue you're hiding with this patch, you probably want to fix the real > > problem instead. > > > Maybe i do not explain it clearly. > The error is detected y some software checking tool. Ok, that's clearer. So it's not an actual bug you saw in practice, I'll modify the changelog accordingly. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/