Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932322Ab3IBVqY (ORCPT ); Mon, 2 Sep 2013 17:46:24 -0400 Received: from mail-bk0-f49.google.com ([209.85.214.49]:41841 "EHLO mail-bk0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758976Ab3IBVqW (ORCPT ); Mon, 2 Sep 2013 17:46:22 -0400 MIME-Version: 1.0 X-Originating-IP: [89.2.206.189] In-Reply-To: References: <1378147630-12471-1-git-send-email-teg@jklm.no> From: Tom Gundersen Date: Mon, 2 Sep 2013 23:46:00 +0200 Message-ID: Subject: Re: [PATCH] input: allow SERIO=m even without EXPERT=y To: Geert Uytterhoeven Cc: richard -rw- weinberger , "linux-input@vger.kernel.org" , LKML , Dmitry Torokhov Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1910 Lines: 49 On Mon, Sep 2, 2013 at 11:30 PM, Geert Uytterhoeven wrote: > On Mon, Sep 2, 2013 at 11:01 PM, richard -rw- weinberger > wrote: >> On Mon, Sep 2, 2013 at 8:47 PM, Tom Gundersen wrote: >>> There is plenty of consumer hardware (e.g., mac books) that does not use >>> AT keyboards or PS/2 mice. It therefore makes sense for distro kernels >>> to build the related drivers as modules to avoid loading them on hardware >>> that does not need them. As such, these options should no longer be protected >>> by EXPERT. >>> >>> Moreover, building these drivers as modules gets rid of the following ugly >>> error during boot: >>> >>> [ 2.337745] i8042: PNP: No PS/2 controller found. Probing ports directly. >>> [ 3.439537] i8042: No controller found >>> >>> Signed-off-by: Tom Gundersen >>> Cc: Dmitry Torokhov >>> --- >>> drivers/input/keyboard/Kconfig | 4 ++-- >>> drivers/input/serio/Kconfig | 6 +++--- >>> 2 files changed, 5 insertions(+), 5 deletions(-) >>> >>> diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig >>> index 269d4c3..2d31cec 100644 >>> --- a/drivers/input/keyboard/Kconfig >>> +++ b/drivers/input/keyboard/Kconfig >>> @@ -2,7 +2,7 @@ >>> # Input core configuration >>> # >>> menuconfig INPUT_KEYBOARD >>> - bool "Keyboards" if EXPERT || !X86 >>> + bool "Keyboards" >> >> Maybe this a stupid question, but why are you dropping the "!X86" too? > > Because the "if EXPERT" only mattered for X86. > > Apply De Morgan and it read like "do not ask the question if !EXPERT && X86". Precisely. -t -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/