Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760034Ab3ICMKy (ORCPT ); Tue, 3 Sep 2013 08:10:54 -0400 Received: from mail-oa0-f41.google.com ([209.85.219.41]:44159 "EHLO mail-oa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760020Ab3ICMKw (ORCPT ); Tue, 3 Sep 2013 08:10:52 -0400 MIME-Version: 1.0 In-Reply-To: <1378204768-18013-1-git-send-email-treding@nvidia.com> References: <1378204768-18013-1-git-send-email-treding@nvidia.com> Date: Tue, 3 Sep 2013 14:10:51 +0200 Message-ID: Subject: Re: [PATCH 1/2] gpio: Fix crash in gpiod_set_debounce() From: Linus Walleij To: Thierry Reding Cc: "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Frank Rowand Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 988 Lines: 28 On Tue, Sep 3, 2013 at 12:39 PM, Thierry Reding wrote: > Return an error if neither the ->set() nor the ->set_debounce() function > is implemented by the chip. Furthermore move locking further down so the > lock doesn't have to be unlocked on error. This is safe to do because at > this point the lock doesn't protect anything. > > Signed-off-by: Thierry Reding > --- > Linus, > > Feel free to squash this into the commit that introduced these: > > fc9bbfb: gpio: improve error path in gpiolib Hm I fixed part of this bug yesterday, but screwed up and left the dangling spinlock in there, what is wrong with me :-( Anyway, fixed it _finally_ now, thanks to you. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/