Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760201Ab3ICRuD (ORCPT ); Tue, 3 Sep 2013 13:50:03 -0400 Received: from mail-ie0-f172.google.com ([209.85.223.172]:53123 "EHLO mail-ie0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760168Ab3ICRuB (ORCPT ); Tue, 3 Sep 2013 13:50:01 -0400 MIME-Version: 1.0 X-Originating-IP: [178.83.130.250] In-Reply-To: <1378229848-29113-1-git-send-email-kamal@canonical.com> References: <1378229848-29113-1-git-send-email-kamal@canonical.com> Date: Tue, 3 Sep 2013 19:50:00 +0200 Message-ID: Subject: Re: [PATCH] drm/i915: i915.disable_pch_pwm overrides PCH_PWM_ENABLE quirk From: Daniel Vetter To: Kamal Mostafa Cc: David Airlie , intel-gfx , dri-devel , Linux Kernel Mailing List Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1103 Lines: 26 On Tue, Sep 3, 2013 at 7:37 PM, Kamal Mostafa wrote: > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=47941 > > Some BIOS configurations of Dell XPS13 are adversely affected by e85843b > ("drm/i915: quirk no PCH_PWM_ENABLE for Dell XPS13 backlight") so provide a > boot param to inhibit the quirk, or force it on. > > i915.disable_pch_pwm can be set to > -1: auto (default; allows the disabling of pch_pwm by dmi quirk table match) > 0: inhibits the disabling of pch_pwm (overrides dmi quirk table match) > 1: forces the disabling of pch_pwm > > Signed-off-by: Kamal Mostafa Nack. Piling quirk over quirk isn't the right approach and I think I should just revert the pch_pwm enable quirk again. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/