Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761607Ab3IDAfy (ORCPT ); Tue, 3 Sep 2013 20:35:54 -0400 Received: from mail-vc0-f181.google.com ([209.85.220.181]:37224 "EHLO mail-vc0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761461Ab3IDAfx (ORCPT ); Tue, 3 Sep 2013 20:35:53 -0400 MIME-Version: 1.0 Date: Wed, 4 Sep 2013 03:35:52 +0300 Message-ID: Subject: drivers/char/hpet.c ACPI parsing From: Tomas Winkler To: "linux-kernel@vger.kernel.org" , Randy Dunlap Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 712 Lines: 22 In hpet_resources function Can anybody explain why we check fixmem32 for NULL, looks strange as it derreferences a member address I'm asking since a static analyzer is complaining about it. } else if (res->id == ACPI_RSTYPE_FIXED_MEM32) { struct acpi_resource_fixed_mem32 *fixmem32; fixmem32 = &res->data.fixed_memory32; if (!fixmem32) ^^^^^^ return -EINVAL; Thanks Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/