Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934215Ab3IDAq0 (ORCPT ); Tue, 3 Sep 2013 20:46:26 -0400 Received: from tundra.namei.org ([65.99.196.166]:34543 "EHLO tundra.namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934093Ab3IDAqZ (ORCPT ); Tue, 3 Sep 2013 20:46:25 -0400 Date: Wed, 4 Sep 2013 10:46:53 +1000 (EST) From: James Morris To: Matthew Garrett cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, keescook@chromium.org, hpa@zytor.com Subject: Re: [PATCH V3 05/11] asus-wmi: Restrict debugfs interface when module loading is restricted In-Reply-To: <1378252218-18798-6-git-send-email-matthew.garrett@nebula.com> Message-ID: References: <1378252218-18798-1-git-send-email-matthew.garrett@nebula.com> <1378252218-18798-6-git-send-email-matthew.garrett@nebula.com> User-Agent: Alpine 2.02 (LRH 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 767 Lines: 21 On Tue, 3 Sep 2013, Matthew Garrett wrote: > We have no way of validating what all of the Asus WMI methods do on a > given machine, and there's a risk that some will allow hardware state to > be manipulated in such a way that arbitrary code can be executed in the > kernel, circumventing module loading restrictions. Prevent that if any of > these features are enabled. > > Signed-off-by: Matthew Garrett Reviewed-by: James Morris -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/