Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934458Ab3IDF5E (ORCPT ); Wed, 4 Sep 2013 01:57:04 -0400 Received: from mail.active-venture.com ([67.228.131.205]:54142 "EHLO mail.active-venture.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934443Ab3IDF5A (ORCPT ); Wed, 4 Sep 2013 01:57:00 -0400 X-Originating-IP: 108.223.40.66 Message-ID: <5226CBAA.10002@roeck-us.net> Date: Tue, 03 Sep 2013 22:56:58 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 MIME-Version: 1.0 To: Matthew Garrett CC: "linux-kernel@vger.kernel.org" , "Thomas.Mingarelli@hp.com" , "toshi.kani@hp.com" , "wim@iguana.be" , "linux-watchdog@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" Subject: Re: [PATCH 1/2] Move and rename HP watchdog timer driver References: <1378272591-9755-1-git-send-email-matthew.garrett@nebula.com> <5226C880.8010704@roeck-us.net> <1378273901.11730.53.camel@x230> In-Reply-To: <1378273901.11730.53.camel@x230> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 790 Lines: 20 On 09/03/2013 10:51 PM, Matthew Garrett wrote: > On Tue, 2013-09-03 at 22:43 -0700, Guenter Roeck wrote: > >> If that is the case, wouldn't it make more sense to have separate drivers, >> one per functionality, plus an mfd driver to bind them all together ? > > It'd be an option, but I don't think there's a huge benefit - the > functionality's reasonably related and there's no real internal bus > architecture on the device. > On the other side it is much cleaner. drivers/mfd/lpc_sch.c and drivers/mfd/lpc_ich.c are good examples. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/