Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763015Ab3IDQLK (ORCPT ); Wed, 4 Sep 2013 12:11:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25750 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757180Ab3IDQLH (ORCPT ); Wed, 4 Sep 2013 12:11:07 -0400 Date: Wed, 4 Sep 2013 12:10:45 -0400 From: Josh Boyer To: Matt Porter Cc: Vinod Koul , Dan Williams , linux-kernel@vger.kernel.org Subject: Re: [PATCH] dma/Kconfig: Make TI_EDMA select TI_PRIV_EDMA Message-ID: <20130904161045.GG12834@hansolo.jdub.homelinux.org> References: <20130904133203.GB12834@hansolo.jdub.homelinux.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130904133203.GB12834@hansolo.jdub.homelinux.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1815 Lines: 44 On Wed, Sep 04, 2013 at 09:32:03AM -0400, Josh Boyer wrote: > The TI_EDMA driver unconditionally calls functions provided by the > TI_PRIV_EDMA code, but it doesn't force that to be built-in. If that isn't > otherwise enabled somewhere, you can get build errors like: > > linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:593: undefined reference to `edma_free_slot' > drivers/built-in.o: In function `edma_terminate_all': > linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:169: undefined reference to `edma_stop' > drivers/built-in.o: In function `edma_execute': > linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:122: undefined reference to `edma_write_slot' > linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:149: undefined reference to `edma_link' > linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:152: undefined reference to `edma_start' > > Make TI_EDMA select TI_PRIV_EDMA to avoid this. > > Signed-off-by: Josh Boyer Just replying to Matt's new email address as the TI one bounced when I originally sent this. > --- > drivers/dma/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig > index daa4da2..825374b 100644 > --- a/drivers/dma/Kconfig > +++ b/drivers/dma/Kconfig > @@ -198,6 +198,7 @@ config TI_EDMA > depends on ARCH_DAVINCI || ARCH_OMAP > select DMA_ENGINE > select DMA_VIRTUAL_CHANNELS > + select TI_PRIV_EDMA > default n > help > Enable support for the TI EDMA controller. This DMA > -- > 1.8.3.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/