Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932790Ab3IDURj (ORCPT ); Wed, 4 Sep 2013 16:17:39 -0400 Received: from eu1sys200aog106.obsmtp.com ([207.126.144.121]:46060 "EHLO eu1sys200aog106.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754438Ab3IDURh convert rfc822-to-8bit (ORCPT ); Wed, 4 Sep 2013 16:17:37 -0400 From: Denis CIOCCA To: Lee Jones Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "jic23@cam.ac.uk" , "arnd@arndb.de" , "linus.walleij@linaro.org" , "linux-iio@vger.kernel.org" Date: Wed, 4 Sep 2013 22:17:09 +0200 Subject: Re: [PATCH 07/11] iio: sensors-core: st: Allow full-scale to be an optional feature Thread-Topic: [PATCH 07/11] iio: sensors-core: st: Allow full-scale to be an optional feature Thread-Index: Ac6pq7ynl0UPv1rcRxeE5CiOsWQPxQ== Message-ID: <52279545.5070903@st.com> References: <1378287103-21765-1-git-send-email-lee.jones@linaro.org> <1378287103-21765-8-git-send-email-lee.jones@linaro.org> In-Reply-To: <1378287103-21765-8-git-send-email-lee.jones@linaro.org> Accept-Language: it-IT, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 acceptlanguage: it-IT, en-US Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2297 Lines: 54 Acked-by: Denis Ciocca > Some chips either don't support it or fail to provide adequate documentation, > so sometimes it's impossible to enable the feature even if it is supported. > > Signed-off-by: Lee Jones > --- > drivers/iio/common/st_sensors/st_sensors_core.c | 11 +++++++---- > drivers/iio/pressure/st_pressure_core.c | 6 ++++-- > 2 files changed, 11 insertions(+), 6 deletions(-) > > diff --git a/drivers/iio/common/st_sensors/st_sensors_core.c b/drivers/iio/common/st_sensors/st_sensors_core.c > index 865b178..fc9acb7 100644 > --- a/drivers/iio/common/st_sensors/st_sensors_core.c > +++ b/drivers/iio/common/st_sensors/st_sensors_core.c > @@ -209,10 +209,13 @@ int st_sensors_init_sensor(struct iio_dev *indio_dev) > if (err < 0) > goto init_error; > > - err = st_sensors_set_fullscale(indio_dev, > - sdata->current_fullscale->num); > - if (err < 0) > - goto init_error; > + if (sdata->current_fullscale) { > + err = st_sensors_set_fullscale(indio_dev, > + sdata->current_fullscale->num); > + if (err < 0) > + goto init_error; > + } else > + dev_info(&indio_dev->dev, "Full-scale not possible\n"); > > err = st_sensors_set_odr(indio_dev, sdata->odr); > if (err < 0) > diff --git a/drivers/iio/pressure/st_pressure_core.c b/drivers/iio/pressure/st_pressure_core.c > index 7ba9299..423ed6a 100644 > --- a/drivers/iio/pressure/st_pressure_core.c > +++ b/drivers/iio/pressure/st_pressure_core.c > @@ -239,8 +239,10 @@ int st_press_common_probe(struct iio_dev *indio_dev) > indio_dev->channels = pdata->sensor->ch; > indio_dev->num_channels = ARRAY_SIZE(st_press_lsp331ap_channels); > > - pdata->current_fullscale = (struct st_sensor_fullscale_avl *) > - &pdata->sensor->fs.fs_avl[0]; > + if (pdata->sensor->fs.addr != 0) > + pdata->current_fullscale = (struct st_sensor_fullscale_avl *) > + &pdata->sensor->fs.fs_avl[0]; > + > pdata->odr = pdata->sensor->odr.odr_avl[0].hz; > > err = st_sensors_init_sensor(indio_dev); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/