Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756735Ab3IDWDD (ORCPT ); Wed, 4 Sep 2013 18:03:03 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:49961 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752955Ab3IDWC7 (ORCPT ); Wed, 4 Sep 2013 18:02:59 -0400 MIME-Version: 1.0 In-Reply-To: References: <306cbe63f85921ad40b00e3c7071be19cb6adf04.1375999914.git.milosz@adfin.com> <18832.1378311843@warthog.procyon.org.uk> <18284.1378315570@warthog.procyon.org.uk> <16226.1378318400@warthog.procyon.org.uk> Date: Wed, 4 Sep 2013 18:02:57 -0400 Message-ID: Subject: Re: [PATCH 2/5] new fscache interface to check cache consistency From: Milosz Tanski To: David Howells Cc: Hongyi Jia , ceph-devel , Sage Weil , "Yan, Zheng" , "linux-cachefs@redhat.com" , "linux-fsdevel@vger.kernel.org" , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1413 Lines: 35 David, Is there anyway I can call you at (at your desk) during EST hours. I'd like to talk this part through since I think we're going a bit in circles. I'd like to get this fixed so we can submit the fscache for Ceph code for the upstream kernel in the merge window. Best, -- Milosz On Wed, Sep 4, 2013 at 3:41 PM, Milosz Tanski wrote: > On Wed, Sep 4, 2013 at 2:13 PM, David Howells wrote: >> Milosz Tanski wrote: >> >>> Is it as simple as stick a mutex at the top of the >>> __fscache_check_consistency function before we try to find the object? >> >> You can lock a mutex in a function, but where are you actually going to place >> the mutex struct? And what other code is going to take it? To do this, you'd >> have to place the mutex struct in fscache_cookie. The problem is that you >> have to protect the pointer from fscache_cookie to fscache_object - so placing >> the mutex in fscache_object doesn't help. > > David, > > I meant lock cookie->lock inside of __fscache_check_consistency in the > beginning of the function. I don't see the need to push this into the > netfs code. > > - Milosz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/