Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762389Ab3IDXos (ORCPT ); Wed, 4 Sep 2013 19:44:48 -0400 Received: from mail-oa0-f47.google.com ([209.85.219.47]:34757 "EHLO mail-oa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762153Ab3IDXop (ORCPT ); Wed, 4 Sep 2013 19:44:45 -0400 Date: Wed, 4 Sep 2013 16:45:04 -0700 From: Kent Overstreet To: kernel neophyte Cc: "linux-bcache@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Stefan Priebe , Jens Axboe Subject: Re: [PATCH] bcache: Fix a shrinker deadlock Message-ID: <20130904234504.GA2635@kmo-pixel> References: <20130830211510.GA20307@kmo-pixel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 778 Lines: 18 On Wed, Sep 04, 2013 at 04:35:50PM -0700, kernel neophyte wrote: > On Fri, Aug 30, 2013 at 2:15 PM, Kent Overstreet wrote: > > GFP_NOIO means we could be getting called recursively - mca_alloc() -> > > mca_data_alloc() - definitely can't use mutex_lock(bucket_lock) then. > > Whoops. > > > > Signed-off-by: Kent Overstreet > > Awesome! I tested the fix... no crashes/deadlock. > But I see lower benchmark numbers for random write.. is this expected > for this change ? No... how much lower? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/