Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763534Ab3IEH6k (ORCPT ); Thu, 5 Sep 2013 03:58:40 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:56153 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763222Ab3IEH6i (ORCPT ); Thu, 5 Sep 2013 03:58:38 -0400 Message-ID: <5228397B.9000502@huawei.com> Date: Thu, 5 Sep 2013 15:57:47 +0800 From: Jianguo Wu User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Andrew Morton CC: Wanpeng Li , Andrea Arcangeli , , Mel Gorman , , , Subject: [PATCH v2] mm/thp: fix stale comments of transparent_hugepage_flags Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.135.74.216] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1855 Lines: 49 Changelog: *v1 -> v2: also update the stale comments about default transparent hugepage support pointed by Wanpeng Li. Since commit 13ece886d9(thp: transparent hugepage config choice), transparent hugepage support is disabled by default, and TRANSPARENT_HUGEPAGE_ALWAYS is configured when TRANSPARENT_HUGEPAGE=y. And since commit d39d33c332(thp: enable direct defrag), defrag is enable for all transparent hugepage page faults by default, not only in MADV_HUGEPAGE regions. Signed-off-by: Jianguo Wu --- mm/huge_memory.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index a92012a..0e42a70 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -26,12 +26,12 @@ #include #include "internal.h" -/* - * By default transparent hugepage support is enabled for all mappings - * and khugepaged scans all mappings. Defrag is only invoked by - * khugepaged hugepage allocations and by page faults inside - * MADV_HUGEPAGE regions to avoid the risk of slowing down short lived - * allocations. +/* By default transparent hugepage support is disabled in order that avoid + * to risk increase the memory footprint of applications without a guaranteed + * benefit. When transparent hugepage support is enabled, is for all mappings, + * and khugepaged scans all mappings. + * Defrag is invoked by khugepaged hugepage allocations and by page faults + * for all hugepage allocations. */ unsigned long transparent_hugepage_flags __read_mostly = #ifdef CONFIG_TRANSPARENT_HUGEPAGE_ALWAYS -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/