Message-ID: <1378376337.1944.26.camel@joe-AO722>
Subject: Re: [PATCH] ALSA: emu10k1: casting (void *) value returned by
 kcalloc is useless
From: Joe Perches <joe@perches.com>
To: Duan Jiong <duanj.fnst@cn.fujitsu.com>
Cc: perex@perex.cz, linux-kernel@vger.kernel.org
Date: Thu, 05 Sep 2013 03:18:57 -0700
In-Reply-To: <5228589C.2060508@cn.fujitsu.com>
References: <52281D37.40808@cn.fujitsu.com>
	 <1378361546.1944.8.camel@joe-AO722> <5228589C.2060508@cn.fujitsu.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2197
Lines: 60

On Thu, 2013-09-05 at 18:10 +0800, Duan Jiong wrote:
> 于 2013年09月05日 14:12, Joe Perches 写道:
> > On Thu, 2013-09-05 at 13:57 +0800, Duan Jiong wrote:
> >> From: Duan Jiong <duanj.fnst@cn.fujitsu.com>
> >>
> >> Casting (void *) value returned by kcalloc is useless
> >> as mentioned in Documentation/CodingStyle, Chap 14.
> > 
> > __user is an important marker that is lost here.
> > 
> >> diff --git a/sound/pci/emu10k1/emufx.c b/sound/pci/emu10k1/emufx.c
> > []
> >> @@ -1183,9 +1183,8 @@ static int _snd_emu10k1_audigy_init_efx(struct snd_emu10k1 *emu)
> >>  	mm_segment_t seg;
> >>  
> >>  	if ((icode = kzalloc(sizeof(*icode), GFP_KERNEL)) == NULL ||
> >> -	    (icode->gpr_map = (u_int32_t __user *)
> >> -	     kcalloc(512 + 256 + 256 + 2 * 1024, sizeof(u_int32_t),
> >> -		     GFP_KERNEL)) == NULL ||
> >> +	    (icode->gpr_map = kcalloc(512 + 256 + 256 + 2 * 1024,
> >> +				sizeof(u_int32_t), GFP_KERNEL)) == NULL ||
> >>  	    (controls = kcalloc(SND_EMU10K1_GPR_CONTROLS,
> >>  				sizeof(*controls), GFP_KERNEL)) == NULL) {
> >>  		err = -ENOMEM;
> > 
> > I think this would be clearer as
> > 
> > 	err = -ENOMEM;
> > 	icode = kzalloc(sizeof(*icode), GFP_KERNEL)
> > 	if (!icode)
> > 		goto err;
> > 	icode->gpr_map = (__user)kcalloc(512 + 256 + 256 + 2 * 1024,
> > 					 sizeof(u_int32_t), GFP_KERNEL);
> > 	if (!icode->gpr_map)
> > 		goto err;
> > 	controls = kcalloc(SND_EMU10K1_GPR_CONTROLS,
> > 			    sizeof(*controls), GFP_KERNEL);
> > 	if (!controls)
> > 		goto err;
> > 
> 
> Maybe it should keep the original style, because i do as you said, and
> error messages appear during compiling the kernel.

I think your suggested patch causes sparse errors when
compiled with "$ make C=2 sound/pci/emu10k1/emufx.o"

And sorry, I just typed my reply in the email client and
I didn't compiled it or anything.

Most likely my suggestion needs a semicolon after the kzalloc
and (__user void *) on the kcalloc cast.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/