Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753240Ab3IEM6N (ORCPT ); Thu, 5 Sep 2013 08:58:13 -0400 Received: from mail-we0-f170.google.com ([74.125.82.170]:64320 "EHLO mail-we0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752231Ab3IEM6M (ORCPT ); Thu, 5 Sep 2013 08:58:12 -0400 Date: Thu, 5 Sep 2013 14:58:08 +0200 From: Frederic Weisbecker To: Ingo Molnar Cc: Linus Torvalds , Linux Kernel Mailing List , Arnaldo Carvalho de Melo , Peter Zijlstra , Thomas Gleixner , Andrew Morton Subject: Re: [GIT PULL] perf changes for v3.12 Message-ID: <20130905125807.GC20519@somewhere> References: <20130903132933.GA24955@gmail.com> <20130905105639.GB21407@gmail.com> <20130905124242.GB20519@somewhere> <20130905125101.GA23591@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130905125101.GA23591@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 943 Lines: 23 On Thu, Sep 05, 2013 at 02:51:01PM +0200, Ingo Molnar wrote: > > * Frederic Weisbecker wrote: > > > > Btw., a side note, append_chain() is a rather confusing function in > > > itself, with logic-inversion gems like: > > > > > > if (!found) > > > found = true; > > > > The check is pointless yeah, I'll remove that. > > Are you sure it can be removed as-is? It inverts the 'found' condition, > which then can be used later on AFAICS. (I haven't looked very deeply > though.) Yeah in fact found is initialized to false. So the if (!found) is always true there. May be it's a leftover from past version that relied on gotos or so. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/