Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752811Ab3IENF7 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 5 Sep 2013 09:05:59 -0400
Received: from mail-ea0-f173.google.com ([209.85.215.173]:53856 "EHLO
	mail-ea0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751522Ab3IENF6 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 5 Sep 2013 09:05:58 -0400
MIME-Version: 1.0
X-Originating-IP: [81.245.33.28]
In-Reply-To: <20130905124508.GE9696@mudshark.cambridge.arm.com>
References: <1378317854-25965-1-git-send-email-jean.pihet@linaro.org>
	<1378317854-25965-4-git-send-email-jean.pihet@linaro.org>
	<20130905124508.GE9696@mudshark.cambridge.arm.com>
Date: Thu, 5 Sep 2013 15:05:57 +0200
Message-ID: <CAORVsuW-1koTMaSMgjagBz1aJ0AtvVRiM5gs3kwO2Fuvk+DhwQ@mail.gmail.com>
Subject: Re: [PATCH 3/3] perf: parse the .debug_frame section in case
 .eh_frame is not present
From: Jean Pihet <jean.pihet@newoldbits.com>
To: Will Deacon <will.deacon@arm.com>
Cc: Jean Pihet <jean.pihet@linaro.org>,
        "linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
        "patches@linaro.org" <patches@linaro.org>,
        Michael Hudson-Doyle <michael.hudson@linaro.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Jiri Olsa <jolsa@redhat.com>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2251
Lines: 89

Hi Will,


On Thu, Sep 5, 2013 at 2:45 PM, Will Deacon <will.deacon@arm.com> wrote:
> Hi Jean,
>
> [adding Michael, since I know he was interested in this]
>
> On Wed, Sep 04, 2013 at 07:04:14PM +0100, Jean Pihet wrote:
>> On ARM the debug info is not present in the .eh_frame sections but
>> instead in .debug_frame.
>> Use libunwind to load and parse the debug info.
>
> How have you tested this? Regardless of whether or not I apply this patch, I
> get the same (broken/truncated) callchains for userspace in perf report.
Here are the commands I have been using:
 perf record -g dwarf -- <binary to profile>
 perf report --sort symbol --call-graph --stdio

>
> E.g. the following stupid program (built with -O0 -g):
>
> --->8
>
> void bar(void)
> {
>         int i;
>         for (i = 0; i < 1000000; ++i)
>                 asm volatile("nop" ::: "memory");
> }
>
> void foo(void)
> {
>         bar();
> }
>
>
> int main(void)
> {
>         foo();
>         return 0;
> }
>
> 8<---
>
> Gives me an incomplete callchain:
>
> # Overhead   Command      Shared Object                           Symbol
> # ........  ........  .................  ...............................
> #
>      0.00%  unwindme  unwindme           [.] bar
>             |
>             --- bar
I get the following with a simple stupid program with a long call chain:
     0.57%  stress_bt  stress_bt          [.] foo_115
            |
            --- foo_115
                foo_114
                foo_113
...
                foo_92
                bar
                doit
                main
                __libc_start_main

Things to check:
- compile the binaries and libraries with -g (-dbg flavor of libs are
usually ok),
- use -g dwarf in perf record


> This is the same with or without your patch.
>
> Will

Thanks for testing!
Jean

>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/