Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753694Ab3IEO7J (ORCPT ); Thu, 5 Sep 2013 10:59:09 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47151 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752813Ab3IEO7I (ORCPT ); Thu, 5 Sep 2013 10:59:08 -0400 Date: Thu, 05 Sep 2013 17:01:20 +0200 Message-ID: From: Takashi Iwai To: Dave Jones Cc: Linux Kernel Mailing List , adi@drcomp.erfurt.thur.de Subject: Re: ALSA: hdspm - AES32: Enable TCO/Sync-In in snd_hdspm_put_sync_ref() In-Reply-To: <20130905145013.GC15894@redhat.com> References: <20130905013837.9F84A660DA9@gitolite.kernel.org> <20130905145013.GC15894@redhat.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1503 Lines: 40 At Thu, 5 Sep 2013 10:50:13 -0400, Dave Jones wrote: > > On Thu, Sep 05, 2013 at 01:38:37AM +0000, Linux Kernel wrote: > > Gitweb: http://git.kernel.org/linus/;a=commit;h=2d60fc7f7d3d79e5646646bb34811961f19d111a > > Commit: 2d60fc7f7d3d79e5646646bb34811961f19d111a > > Parent: dbae4a0c8d8794df1a6bd7e644ed94b915f46f7e > > Author: Adrian Knoth > > AuthorDate: Fri Jul 5 11:28:15 2013 +0200 > > Committer: Takashi Iwai > > CommitDate: Fri Jul 5 14:52:42 2013 +0200 > > > > ALSA: hdspm - AES32: Enable TCO/Sync-In in snd_hdspm_put_sync_ref() > > > static int hdspm_autosync_ref(struct hdspm *hdspm) > > { > ... > > + unsigned int syncref = (status >> HDSPM_AES32_syncref_bit) & 0xF; > > + if ((syncref >= HDSPM_AES32_AUTOSYNC_FROM_WORD) && > > + (syncref <= HDSPM_AES32_AUTOSYNC_FROM_SYNC_IN)) { > > return syncref; > > + } > > Because syncref is unsigned, the first part of that if always evaluates true. > (it will always be >0) True. But from the coding POV, it's not so bad to show both "from" and "to" for clearly indicating a range, IMO. (And the compiler should be cleverer than the programmer and will optimize it out in anyway :) thanks, Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/