Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754182Ab3IEPdl (ORCPT ); Thu, 5 Sep 2013 11:33:41 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:38077 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752206Ab3IEPdg (ORCPT ); Thu, 5 Sep 2013 11:33:36 -0400 From: Frederic Weisbecker To: LKML Cc: Frederic Weisbecker , Benjamin Herrenschmidt , Paul Mackerras , Ingo Molnar , Thomas Gleixner , Peter Zijlstra , "H. Peter Anvin" , Linus Torvalds , James Hogan , "James E.J. Bottomley" , Helge Deller , Martin Schwidefsky , Heiko Carstens , "David S. Miller" , Andrew Morton Subject: [PATCH 3/3] irq: Comment on the use of inline stack for ksoftirq Date: Thu, 5 Sep 2013 17:33:24 +0200 Message-Id: <1378395204-25342-4-git-send-email-fweisbec@gmail.com> X-Mailer: git-send-email 1.7.5.4 In-Reply-To: <1378395204-25342-1-git-send-email-fweisbec@gmail.com> References: <1378330796.4321.50.camel@pasglop> <1378395204-25342-1-git-send-email-fweisbec@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1579 Lines: 46 Ksoftirqd shouldn't need softirq stack since it's executing in a kernel thread with a callstack that is only beginning at this stage. Lets comment about that for clarity. Signed-off-by: Frederic Weisbecker Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Ingo Molnar Cc: Thomas Gleixner Cc: Peter Zijlstra Cc: H. Peter Anvin Cc: Linus Torvalds Cc: Paul Mackerras Cc: James Hogan Cc: James E.J. Bottomley Cc: Helge Deller Cc: Martin Schwidefsky Cc: Heiko Carstens Cc: David S. Miller Cc: Andrew Morton --- kernel/softirq.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/kernel/softirq.c b/kernel/softirq.c index 657e047..1de0322 100644 --- a/kernel/softirq.c +++ b/kernel/softirq.c @@ -759,6 +759,7 @@ static void run_ksoftirqd(unsigned int cpu) { local_irq_disable(); if (local_softirq_pending()) { + /* No need to use softirq stack here */ __do_softirq(); rcu_note_context_switch(cpu); local_irq_enable(); -- 1.7.5.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/