Message-ID: <5228A9FA.90003@mm-sol.com>
Date: Thu, 05 Sep 2013 18:57:46 +0300
From: Georgi Djakov <gdjakov@mm-sol.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8
MIME-Version: 1.0
To: Jaehoon Chung <jh80.chung@samsung.com>
CC: linux-mmc@vger.kernel.org, cjb@laptop.org, grant.likely@linaro.org,
        rob.herring@calxeda.com, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        Asutosh Das <asutoshd@codeaurora.org>,
        Venkat Gopalakrishnan <venkatg@codeaurora.org>,
        Sahitya Tummala <stummala@codeaurora.org>,
        Subhash Jadavani <subhashj@codeaurora.org>
Subject: Re: [PATCH RFC v3] mmc: sdhci-msm: Add support for MSM chipsets
References: <1377017077-9834-1-git-send-email-gdjakov@mm-sol.com> <521C699A.2010609@samsung.com>
In-Reply-To: <521C699A.2010609@samsung.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 936
Lines: 29

Hi Jaehoon,

On 08/27/2013 11:55 AM, Jaehoon Chung wrote:
> Hi Georgi,
>
> I found the sdhci_msm_vreg_reset(). Why do you run enable->disable?
>
> +/*
> + * Reset vreg by ensuring it is off during probe. A call
> + * to enable vreg is needed to balance disable vreg
> + */
> +static int sdhci_msm_vreg_reset(struct sdhci_msm_pltfm_data *pdata)
>
> I think that controller didn't have responsibility to ensure whether power is enabled or not at probing time.
> If just needed to balance vreg, then i think this function can be removed.
> How about?
>
> Also before using regulator_is_enabled(), i had found the hole for balancing the vreg.

Thank you! I'll remove this function.

BR,
Georgi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/