Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751122Ab3IFJiH (ORCPT ); Fri, 6 Sep 2013 05:38:07 -0400 Received: from mail-ee0-f50.google.com ([74.125.83.50]:53984 "EHLO mail-ee0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750884Ab3IFJiF (ORCPT ); Fri, 6 Sep 2013 05:38:05 -0400 Date: Fri, 6 Sep 2013 10:38:00 +0100 From: Lee Jones To: Sachin Kamat Cc: linux-kernel@vger.kernel.org, anton@enomsg.org, dwmw2@infradead.org Subject: Re: [PATCH v3 1/4] ab8500-charger: Check return value of regulator_enable Message-ID: <20130906093800.GF32654@lee--X1> References: <1378454473-24508-1-git-send-email-sachin.kamat@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1378454473-24508-1-git-send-email-sachin.kamat@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1151 Lines: 36 On Fri, 06 Sep 2013, Sachin Kamat wrote: > Check the return value of regulator_enable to silence the following > type of warnings: > drivers/power/ab8500_charger.c:1390:20: warning: ignoring return value > of ‘regulator_enable’, declared with attribute warn_unused_result > [-Wunused-result] > > Signed-off-by: Sachin Kamat > Cc: Lee Jones > --- > Compile tested. > > Changes since v2: > * removed redundant assignment to false. > Changes since v1: > * converted dev_err and return to dev_warn as suggested by Lee Jones. > --- > > drivers/power/ab8500_charger.c | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) Looks good now. Acked-by: Lee Jones -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/